Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38980: Add -fno-semantic-interposition when building with optimizations #22862

Merged
merged 2 commits into from Oct 21, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 21, 2020

@pablogsal pablogsal force-pushed the pablogsal:bpo-38980 branch 4 times, most recently from 3f082bf to ebb205c Oct 21, 2020
@pablogsal pablogsal force-pushed the pablogsal:bpo-38980 branch from ebb205c to ae60fa3 Oct 21, 2020
@@ -6482,6 +6482,14 @@ if test "$Py_OPT" = 'true' ; then
DEF_MAKE_ALL_RULE="profile-opt"
REQUIRE_PGO="yes"
DEF_MAKE_RULE="build_all"
case $CC in

This comment has been minimized.

@pablogsal

pablogsal Oct 21, 2020
Author Member

There is no conditional activation on --enable-shared because C extensions can also benefit from this (and they inherit the build flags).

@pablogsal pablogsal requested review from vstinner, methane and encukou Oct 21, 2020
Copy link
Member

@encukou encukou left a comment

I see one ReST syntax issue, otherwise LGTM

Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@pablogsal pablogsal merged commit b451b0e into python:master Oct 21, 2020
10 checks passed
10 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
Azure Pipelines PR #20201021.62 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 38980 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
lisroach added a commit to lisroach/cpython that referenced this pull request Oct 24, 2020
adorilson added a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal pablogsal deleted the pablogsal:bpo-38980 branch May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants