Test with php8 on windows #15325
Merged
Test with php8 on windows #15325
Conversation
| $this->assertTimeFormat($expected, $result); | ||
|
|
||
| $result = $time->i18nFormat(\IntlDateFormatter::FULL, 'Asia/Tokyo', 'ja-JP@calendar=japanese'); | ||
| $expected = '平成22年1月14日木曜日 22時59分28秒 日本標準時'; |
markstory
Feb 23, 2021
Member
Should we have some tests left behind for non-gregorian calendars?
Should we have some tests left behind for non-gregorian calendars?
othercorey
Feb 23, 2021
Author
Member
Yea, we should since we parse it to set the traditional calendar flag.
Yea, we should since we parse it to set the traditional calendar flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.