Skip to content

/ graphtage

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expects quoted attributes in HTML unnecessarily, preventing diffing #25

Open
technopagan opened this issue Aug 31, 2020 · 1 comment
Open

Expects quoted attributes in HTML unnecessarily, preventing diffing #25

technopagan opened this issue Aug 31, 2020 · 1 comment
Assignees
@ESultanik
Labels
bug enhancement good first issue

Comments

@technopagan
Copy link

@technopagan technopagan commented Aug 31, 2020

When trying to diff an HTML file, Graphtage throws an error when encountering e.g.:

<meta name=foo

because it expects quoted attributes like so:

<meta name="foo"

However, the first variant without quotes is perfectly valid HTML and should not prevent Graphtage from diffing the file.
@technopagan technopagan changed the title Throws errors on valid HTML Expects quoted attributes in HTML unnecessarily, preventing diffing Aug 31, 2020
@ESultanik ESultanik added the bug label Sep 3, 2020
@ESultanik ESultanik self-assigned this Sep 3, 2020
@ESultanik ESultanik added enhancement good first issue labels Sep 3, 2020
@ESultanik
Copy link
Collaborator

@ESultanik ESultanik commented Sep 3, 2020

This is because Graphtage is (incorrectly) currently using Python's XML parser to parse HTML. This is a bug. We need to switch to an actual HTML parser. I will use this issue to track that development.
@technopagan technopagan mentioned this issue Sep 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ESultanik ESultanik

Labels
bug enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@technopagan @ESultanik