Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing mod_generics_cache.py to MANIFEST.in #406

Merged
merged 2 commits into from Mar 27, 2017
Merged

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Mar 27, 2017

This is needed for python setup.py test to work on the source distribution.

In the 3.6.1 release package that one test (test_generic_hashes) fails now on Pythons < 3.6.1. I don't think it's urgent enough to release 3.6.1.1 right away, but it would be nice to have this fixed for the next release.

MANIFEST.in Outdated
include python2/typing.py
include python2/test_typing.py
include python2/test_typing.py

This comment has been minimized.

@refi64

refi64 Mar 27, 2017
Contributor

...is there a reason you duplicated the line, or was it just rogue copy-paste?

This comment has been minimized.

@ambv

ambv Mar 27, 2017
Author Contributor

Yeah, my Vi foo failed.

@ilevkivskyi
Copy link
Collaborator

@ilevkivskyi ilevkivskyi commented Mar 27, 2017

Thanks! I completely forgot about adding these files to MANIFEST.in

@ilevkivskyi ilevkivskyi merged commit 7dfedb2 into master Mar 27, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@gvanrossum gvanrossum deleted the mod_generics_cache branch Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.