Skip to content

/ oppia

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all migrated object factories to model.ts files in angular. #10700

Open
srijanreddy98 opened this issue Sep 17, 2020 · 22 comments
Open

Refactor all migrated object factories to model.ts files in angular. #10700

srijanreddy98 opened this issue Sep 17, 2020 · 22 comments
Labels
good first issue
Projects
Angular 8 migration

Comments

@srijanreddy98
Copy link
Member

@srijanreddy98 srijanreddy98 commented Sep 17, 2020 •
edited by DubeySandeep

We have a new convention in the codebase for structuring data. Previously we used Object Factories but since the codebase is completely in Typescript, we can now move to typescript classes.

You can find instructions on how to migrate here. You can use #10701 and #10713 as reference examples.

If you want to work on any unclaimed Object Factory in this tracker, please add a comment in this thread and tag @srijanreddy98, and we'll add you as an assignee. It will be all yours then. This is done so that we don't have any duplication of work.

Unclaimed:

  • ThreadMessageSummary
  • Units
  • Fraction
  • PlaythroughIssue
  • LostChange
  • StateCard

Claimed:

Finished:

Design Doc: https://docs.google.com/document/d/1AH2phvdQ_nTlIVTqK2wLX-BopowCsoaIhCDHRMUsl9s/edit?usp=sharing
@darksun27 darksun27 mentioned this issue Sep 17, 2020
Merged
4 of 4 tasks complete
@nairnikhil12 nairnikhil12 mentioned this issue Sep 18, 2020
Merged
4 of 4 tasks complete
@darksun27 darksun27 mentioned this issue Oct 1, 2020
Merged
4 of 4 tasks complete
@dchen97 dchen97 added the gracehopperOSD label Oct 1, 2020
@srijanreddy98 srijanreddy98 added this to To do in Angular 8 migration via automation Oct 1, 2020
@justlitatheng justlitatheng mentioned this issue Oct 1, 2020
Merged
4 of 4 tasks complete
nithusha21 pushed a commit that referenced this issue Oct 2, 2020
@justlitatheng justlitatheng
Fixes Part of #10700: Refactor state stats object factory (#10844)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52c80a7 
* refactoring state stats model

* refactoring state stats model

Co-authored-by: justlitatheng <laklitatheng@gmail.com>
seanlip pushed a commit that referenced this issue Oct 5, 2020
@nairnikhil12
Fix Part of #10700: Refactor Object Factories (#10713)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ae25baf 
* refactor topic-rights.model.ts

* refactor ParamMetadata partially

* refactor ParamMetadata

* refactor ExplorationMetadata

* Refactor LearnerDashboardActivityIdsModel

* Refactor AutogeneratedAudioLanguage

* Refactor ImageFileObjectFactory

* Refactor AudioLanguageObjectFactory

* Refactor StopwatchObjectFactory

* Refactor AudioFileObjectFactory

* Refactor EntityContextObjectFactory

* Refactor FileDownloadRequestObjectFactory

* Refactor ClassifierObjectFactory

* Refactor PredictionResultObjectFactory

* Refactor AnswerClassificationResultObjectFactory

* Refactor TopicsAndSkillsDashboardObjectFactory

* Refactor NewlyCreatedTopicObjectFactory

* Refactor StorySummaryObjectFactory

* fix errors

* Refactor ChangeObjectFactory

* Refactor FeedbackThreadSummary

* Refactor ExplorationDraftObjectFactory

* fix linting errors

* fix typescript errors

* resolve conflicts

* fix formatting issues

* fix linting issues

* resolve typescript errors

* correct fileoverview of .model.spec.ts files

* remove create methods in model classes

* resolve errors

* remove unused imports

* refactor StoryNodeObjectFactory

* fix linting errors

* update imports

* correct the importing order
@darksun27 darksun27 mentioned this issue Oct 5, 2020
Merged
4 of 4 tasks complete
@arpit1912
Copy link
Collaborator

@arpit1912 arpit1912 commented Oct 7, 2020

@srijanreddy98 can I take up CollectionNode object factory. Thanks!
@darksun27
Copy link
Member

@darksun27 darksun27 commented Oct 8, 2020

Hey! @arpit1912, CollectionNode is already migrate and is in the review phase. Could you please take some other ObjectFactory. Sorry for the inconvenience.
srijanreddy98 pushed a commit that referenced this issue Oct 10, 2020
@darksun27
Fix Part of #10700: Refactor Object Factories (#10701)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6064113 
* Refactor Collection Summary Object Factory

* Refactor Skill Summary Object Factory

* Refactor Assigned Skill Object Factory

* Refactor Augmented Skill Summary Object Factory

* Refactor Exploration Improvements Config Object Factory

* Refactor Computation Data Object Factory

* Refactor Job Status Summary Object Factory

* Refactor Job Data Object Factory

* Refactor Profile Summary Object Factory

* Refactor Review Test Object Factory

* Refactor Exploration Permission Object Factory

* Refactor Visualization Info Onject Factory

* Refactor Non Existent Activities Object Factory

* Refactor Creator Dashboard Stats Object Factory

* Refactor Client Context Object Factory

* Refactor Feature Status Summary Object Factory

* Refactor Creator Exploration Summary Object Factory

* Refactor Learner Answer Info Object Factory

* Refactor Learner Answer Details Object Factory

* Refactor Featured Translation language Object Factory

* Fix Linting Issues

* Refactor Exploration Opportunity Summary Object Factory

* Fix Formatting Issues

* Fix Formattion Issues and Backend Test

* Fix Import Issues

* Fix Merge Conflicts

* Fix Formatting Issues

* Fix Compilation Errors

* Fix formatting issues

* Fix Formatting issues

* Fix linting issues
srijanreddy98 pushed a commit that referenced this issue Oct 18, 2020
@darksun27
Fix part of #10700: Refactor Object Factories with Dependencies (#10868)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a63fe8a 
* Refactor Collection Node Object Factory

* Refactor Collection Object Factory

* Refactor Email Query Deashboard and Email Query Dashboard Results Object Factories

* Refactor Platform Parameter Filter, Rule Object Factories

* Refactor Exploration Stats Object Factories

* Refactor LearnerExplorationSummary and UserProfile Object Factories

* Refactor ReadOnlyStoryNode and StoryPlaythrough Object Factories

* Refactor TopicSummary and ClassroomData Object Factories

* Refactor HighBounceRateTask Object Factory

* Refactor SuccessiveIncorrectAnswerTask IneffectiveFeedbackLoopTask NeedsGuidingResponseTask and ExplorationTask Object Factories

* Fix coverage

* Fix coverage

* Fix coverage

* Fix Coverage

* Fix Review Issues

* Fix Frontend Test Issues

* Add TODO(#10875): Fix type mismatch

* Add TODO(#10875): Fix type mismatch

* Fix Merge conflicts in angular-services

* Fix compile issues
seanlip pushed a commit that referenced this issue Oct 21, 2020
@darksun27
Fix Part of #10700: Refactor Object Factories (#10838)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
31295f1 
* Refactor SkillOpportunityObjectFactory

* Refactor CollectionRightsObjectFactory

* Refactor GuestCollectionProgressObjectFactory

* Refactor SkillDifficultyObjectFactory

* Refactor SkillMasteryObjectFactory

* Refactor SkillRightsObjectFactory

* Refactor FeedbackMessageSummaryObjectFactory

* Refactor TaskEntryObjectFactory

* Refactor RatioObjectFactory

* Refactor UserInfoObjectFactory

* Refactor NewlyCreatedStoryObjectFactory

* Fix Frontend Tests

* Fix Linting Issues

* Fix Linting Issues

* Fix linting issues

* Fix linting issues

* Fix Linting Issues

* Fix minor formatting issue

* Fix minor formatting issues
@DubeySandeep DubeySandeep removed the gracehopperOSD label Oct 28, 2020
@mridul-netizen
Copy link
Collaborator

@mridul-netizen mridul-netizen commented Jan 7, 2021

@darksun27 Can I work on Learner Action object factory.Thanks!
@darksun27
Copy link
Member

@darksun27 darksun27 commented Jan 7, 2021

@mridul-netizen assigned to you!
@darksun27 darksun27 added the good first issue label Jan 8, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jan 8, 2021

Hi @darksun27, thanks for proposing this as a good first issue. I am removing the label for now and looping in @vojtechjelinek to approve the label. It will be added back if approved. Thanks!
@github-actions github-actions bot removed the good first issue label Jan 8, 2021
@github-actions github-actions bot assigned vojtechjelinek Jan 8, 2021
@vojtechjelinek vojtechjelinek added the good first issue label Jan 8, 2021
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Jan 8, 2021

@jameesjohn Why was I assigned here and not Sandeep? Maybe some code is not deployed?
@parulpriyedarshani
Copy link
Collaborator

@parulpriyedarshani parulpriyedarshani commented Jan 13, 2021 •
edited

@srijanreddy98 I would like to work on AnswerStats Object Factory. Could you please assign it to me?
Thanks.
@parulpriyedarshani
Copy link
Collaborator

@parulpriyedarshani parulpriyedarshani commented Jan 14, 2021

@srijanreddy98 I have already made a commit and I'm opening a PR for the same. Could you please assign the requested file to me? Thanks.
@parulpriyedarshani parulpriyedarshani mentioned this issue Jan 14, 2021
Open
0 of 4 tasks complete
@srijanreddy98
Copy link
Member Author

@srijanreddy98 srijanreddy98 commented Jan 14, 2021

@parulpriyedarshani done!
@mridul-netizen
Copy link
Collaborator

@mridul-netizen mridul-netizen commented Jan 15, 2021

@darksun27 LearnerActionObjectFactory.ts file already contains a type LearnerAction so can I rename my LeanerActionObjectFactory to LearnerActionModel?
@darksun27
Copy link
Member

@darksun27 darksun27 commented Jan 15, 2021

@darksun27 LearnerActionObjectFactory.ts file already contains a type LearnerAction so can I rename my LeanerActionObjectFactory to LearnerActionModel?

it would be learner-action.model.ts
@vojtechjelinek vojtechjelinek removed their assignment Jan 17, 2021
@mridul-netizen
Copy link
Collaborator

@mridul-netizen mridul-netizen commented Jan 22, 2021

@darksun27 As per @brianrodri this PR requires some code refractoring. Can you assign me ThreadMessageSummary for the meanwhile.
@Nik-09
Copy link
Collaborator

@Nik-09 Nik-09 commented Jan 27, 2021 •
edited

@vojtechjelinek @darksun27 @srijanreddy98 can you please assign QuestionSummary to me.
Thanks
@amulya00
Copy link
Contributor

@amulya00 amulya00 commented Feb 3, 2021

@srijanreddy98 @darksun27 , can I work on Suggestion ? thanks.
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Feb 3, 2021

@amulya00 I have assigned you.
@DubeySandeep
Copy link
Member

@DubeySandeep DubeySandeep commented Feb 6, 2021

Assigned QuestionSummary part of the issue to @Nik-09
@mridul-netizen mridul-netizen mentioned this issue Feb 9, 2021
Closed
4 of 4 tasks complete
@Nik-09 Nik-09 mentioned this issue Feb 10, 2021
Merged
4 of 4 tasks complete
DubeySandeep pushed a commit that referenced this issue Feb 13, 2021
@Nik-09
Fix Part of #10700: Convert Object factory to Model Class (#11902)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
989cc4f
amulya00 added a commit to amulya00/oppia that referenced this issue Feb 13, 2021
@amulya00
Fix Part of oppia#10700: Refactor suggestion object factory
77601b6
amulya00 added a commit to amulya00/oppia that referenced this issue Feb 13, 2021
@amulya00
Fix Part of oppia#10700: Refactor suggestion object factory
1192261
@amulya00 amulya00 mentioned this issue Feb 13, 2021
Merged
0 of 4 tasks complete
amulya00 added a commit to amulya00/oppia that referenced this issue Feb 13, 2021
@amulya00
Fix Part of oppia#10700: Refactor suggestion object factory
6c9f513
amulya00 added a commit to amulya00/oppia that referenced this issue Feb 13, 2021
@amulya00
Fix Part of oppia#10700: Refactor suggestions object factory
be119b5
@suryasiriki4
Copy link
Contributor

@suryasiriki4 suryasiriki4 commented Feb 15, 2021 •
edited

@srijanreddy98, can you please assign me StateCard? thank you.
amulya00 added a commit to amulya00/oppia that referenced this issue Feb 15, 2021
@amulya00
Fix Part of oppia#10700: Refactor suggestion object factory
d9282f3
amulya00 added a commit to amulya00/oppia that referenced this issue Feb 15, 2021
@amulya00
Fix Part of oppia#10700: Refactor suggestion object factory
7340747
@illusionist301
Copy link

@illusionist301 illusionist301 commented Feb 17, 2021 •
edited

can i work on PlaythroughIssue? @srijanreddy98
amulya00 added a commit to amulya00/oppia that referenced this issue Feb 23, 2021
@amulya00
Fix Part of oppia#10700: Refactor suggestion object factory
66d5142
srijanreddy98 pushed a commit that referenced this issue Mar 5, 2021
@amulya00
Fixes Part of #10700: Refactor Suggestions object factory (#11942)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f9dd6c 
* Fix part of #10306: Added async keyword to functions that return a promise

* added async keyword to function getExplorationStatsAsync

* Update exploration-improvements-task-registry.service.ts

* Made necessary changes

* removed unnecessary newline

* Fix Part of #10700: Refactor suggestion object factory

* Fix Part of #10700: Refactor suggestion object factory

* Fix Part of #10700: Refactor suggestion object factory

* Fix Part of #10700: Refactor suggestions object factory

* Fix Part of #10700: Refactor suggestion object factory

* Fix Part of #10700: Refactor suggestion object factory

* Fixed indentation in suggestion.model.ts

* Fixed indentation in suggestion.model.ts

* Fixed indentation in suggestion.model.ts

* Fix Part of #10700: Refactor suggestion object factory

* Fixed suggestion.model.ts

* Fixed suggestion.model.ts

* Fixed typerscript errors

* Fixed typerscript errors

* Fixed typerscript errors

* Fixed typerscript errors

* Fixed typerscript errors

* typerscript errors

* typerscript errors

* typerscript errors

* typerscript errors
@sachinchauhan2889
Copy link
Collaborator

@sachinchauhan2889 sachinchauhan2889 commented Mar 6, 2021

@srijanreddy98 please assign me ThreadMessageSummary
@sachinchauhan2889 sachinchauhan2889 mentioned this issue Mar 6, 2021
Closed
4 of 4 tasks complete
@mridul-netizen
Copy link
Collaborator

@mridul-netizen mridul-netizen commented Mar 6, 2021

@sachinchauhan2889 I am already working on it and have opened a PR can you work on some other file?
@sachinchauhan2889
Copy link
Collaborator

@sachinchauhan2889 sachinchauhan2889 commented Mar 6, 2021

@mridul-netizen sorry i haven't seen Your PR. I only see unclaimed list and create PR.
You can continue you work. I will close my PR.
@sachinchauhan2889
Copy link
Collaborator

@sachinchauhan2889 sachinchauhan2889 commented Mar 6, 2021

@srijanreddy98 can you please assign me fraction.
@sachinchauhan2889 sachinchauhan2889 mentioned this issue Mar 7, 2021
Open
4 of 4 tasks complete
@mridul-netizen mridul-netizen mentioned this issue Mar 9, 2021
Merged
4 of 4 tasks complete
srijanreddy98 pushed a commit that referenced this issue Mar 9, 2021
@mridul-netizen
Fix Part Of #10700 Refractor ThreadMessageSummaryObjectFactory and Th…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
86e6c02 
…readMessageObjectFactory to Model (#12060)

* updated

* updated

* refracted threadmessageobjectfactory

* removed createNew

* updated

* updated

* updated
17sushmita added a commit to 17sushmita/oppia that referenced this issue Mar 10, 2021
@Nik-09 @17sushmita
Fix Part of oppia#10700: Convert Object factory to Model Class (oppia…
6e27022 
…#11902)
17sushmita added a commit to 17sushmita/oppia that referenced this issue Mar 10, 2021
@amulya00 @17sushmita
Fixes Part of oppia#10700: Refactor Suggestions object factory (oppia…
2ca1903 
…#11942)

* Fix part of oppia#10306: Added async keyword to functions that return a promise

* added async keyword to function getExplorationStatsAsync

* Update exploration-improvements-task-registry.service.ts

* Made necessary changes

* removed unnecessary newline

* Fix Part of oppia#10700: Refactor suggestion object factory

* Fix Part of oppia#10700: Refactor suggestion object factory

* Fix Part of oppia#10700: Refactor suggestion object factory

* Fix Part of oppia#10700: Refactor suggestions object factory

* Fix Part of oppia#10700: Refactor suggestion object factory

* Fix Part of oppia#10700: Refactor suggestion object factory

* Fixed indentation in suggestion.model.ts

* Fixed indentation in suggestion.model.ts

* Fixed indentation in suggestion.model.ts

* Fix Part of oppia#10700: Refactor suggestion object factory

* Fixed suggestion.model.ts

* Fixed suggestion.model.ts

* Fixed typerscript errors

* Fixed typerscript errors

* Fixed typerscript errors

* Fixed typerscript errors

* Fixed typerscript errors

* typerscript errors

* typerscript errors

* typerscript errors

* typerscript errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
Angular 8 migration
  
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet