Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cdk/clipboard): Add imports to samples #21910

Merged
merged 1 commit into from Apr 22, 2022
Merged

Conversation

kirjs
Copy link
Contributor

@kirjs kirjs commented Feb 15, 2021

Standalone Clipboard samples have been missing imports, which can confuse some devs.
I added them.

@kirjs kirjs requested a review from jelbourn as a code owner Feb 15, 2021
@google-cla google-cla bot added the cla: yes label Feb 15, 2021
Copy link
Member

@crisbeto crisbeto left a comment

The change looks good, but the CI is failing, because the commit title is incorrect. It should be docs(cdk/clipboard) instead of docs(material/clipboard).

@kirjs kirjs changed the title docs(material/clipboard): Add imports to samples docs(cdk/clipboard): Add imports to samples Feb 26, 2021
@kirjs
Copy link
Author

@kirjs kirjs commented Feb 26, 2021

PTAL

Some samples have been missing imports, which can confuse some devs.
I added them.
@andrewseguin andrewseguin removed the cla: yes label Dec 28, 2021
@andrewseguin andrewseguin added merge ready merge safe target: patch labels Apr 22, 2022
@andrewseguin andrewseguin merged commit 54cb83e into angular:master Apr 22, 2022
6 of 18 checks passed
andrewseguin pushed a commit that referenced this issue Apr 22, 2022
Some samples have been missing imports, which can confuse some devs.
I added them.

(cherry picked from commit 54cb83e)
diprokon pushed a commit to diprokon/components that referenced this issue Apr 28, 2022
Some samples have been missing imports, which can confuse some devs.
I added them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge ready merge safe target: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants