This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Add models for gopkg.in/yaml#475
Merged
Merged
Conversation
smowton
approved these changes
Feb 11, 2021
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Looks good! Let's have an eval status checklist here too
|
|
||
| FunctionModels() { | ||
| this.hasQualifiedName(packagePath(), "NewDecoder") and | ||
| (inp.isParameter(0) and outp.isResult()) |
Contributor
There was a problem hiding this comment.
redundant parens, here and elsewhere
Contributor
Author
There was a problem hiding this comment.
I copied the style here from our the autogenerated models because it felt cleaner.
| @@ -0,0 +1,70 @@ | |||
| /** | |||
| * Provides classes for working with the [gopkg.in/yaml](https://pkg.go.dev/gopkg.in/yaml.v3) package. | |||
Contributor
There was a problem hiding this comment.
Looks like we support more than .v3?
Contributor
Author
There was a problem hiding this comment.
I didn't think it would be very necessary to mention all of them so I chose v3 arbitrarily as the one to link to. They actually have a site that we could link to instead.
Contributor
There was a problem hiding this comment.
Ah, I didn't notice that was the target of the link not its text; that's fine then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.