Make Title and Message settable in Credential Attribute #14522
+27
−7
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Make Title and Message settable in Credential Attribute
For parity with Get-Credential, this exposes
TitleandMessageproperties in the Credential attribute, while maintaining the current behavior.Requested by @potatoqualitee ...
https://twitter.com/cl/status/1339896630863159296
The key feature request was to be able to customize the prompt for the password even when a username was being passed to the Credential parameter.
Note: I've not touched any tests here. If anyone who thinks something more should be done can point me in the right direction, I'm happy to do it.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.