Fixing typos in turtle.rst#24385
Merged
nanjekyejoannah merged 5 commits intopython:mainfrom May 30, 2021
Merged
Conversation
serverwentdown
approved these changes
Feb 11, 2021
Contributor
serverwentdown
left a comment
serverwentdown
left a comment
There was a problem hiding this comment.
LGTM, minor changes.
| dialog window, prompt is a text mostly describing what numerical information | ||
| to input. default: default value, minval: minimum value for input, | ||
| maxval: maximum value for input | ||
| maxval: maximum value for input. |
Contributor
There was a problem hiding this comment.
I think this is better rewritten as:
... *title* is the title of the dialog window, *prompt* is a text mostly describing what numerical information to input. *default* is a default value to fill the input with.
The number input must be in the range *minval* .. *maxval* (inclusive) if these are given. If outside of this range, a hint is issued and the dialog remains open for correction.
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
nanjekyejoannah
left a comment
nanjekyejoannah
left a comment
There was a problem hiding this comment.
Since there is no activity to add the requested changes, and PR went stale, I will merge as-is for now.
@serverwentdown, you can open a PR for your suggestions if you wish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even more typos. (I'll keep updating the PR as I find more or open new ones)