Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix text objects to be line-wise rather than character-wise operator #1037
Conversation
b760bef
to
a59310e
|
Hi @lieryan ! Sorry for this massive late feedback. I've had tough personal issues last year that made me stay away from this project (even from my work). I still don't have too much time to dedicate to the project, but I'll try to get back to it. Can you please provide a minimal working example for me to test the behavior before and after your change? Like, a simple Thank you very much for your contribution! Oh, and please, also add yourself to the Authors file! |
|
Hi, thanks for coming back. I've added actual test for the So a test example would be:
If you used the daM on
After the change, the buffer content will now look like (note the position of
This works similar to other line-wise text objects like |
b194e79
to
242c2de
For some reason, vim will still add packages even when -u is specified. This flag tells vim to avoid loading those packages. This should improve test isolation.
242c2de
to
ff89053
|
Thank you very much for your contribution! :) (better late than never!) |
The text objects command like
daCanddiMpreviously worked using character-wise selection. This is rarely what the user want, as it means that pasting with (p) does not work if your cursor is not on column 0 and paste with reindent (]p) does not work at all.This PR changes these text objects to be line-wise, which aligns it with other similar builtin motion commands like dap/dip (delete a/inner paragraph).
All tests seems to pass, though I'm not quite sure how to add a new test for this.