replaced timing_safe_cmp implementation with Subtle #2366
Conversation
orf
changed the title
|
If we regard RustPython core modules as a library, caret or tilde notation will give a bit of freedom for users |
| } | ||
|
|
||
| result == 0 | ||
| a.ct_eq(b).into() |
There was a problem hiding this comment.
I think if we're just using subtle, we could just depend on subtle from rustpython-vm and remove the cmp module here.
|
I think caret is the default:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html This is just so that CI and stuff uses updated versions, if I understand correctly. |
|
Also, I'm not sure if default-members is the desirable behavior, |
youknowone
changed the title
|
This PR was covering too much things in a single PR. I rebased it without outdated stuff. |
This PR runs
cargo upgradeon the project and fixes associated errors.I replaced
timing_safe_cmpwith Subtle rather than trying to upgrade the code to use the new version ofvolatile. I think Subtle is a good crate to rely on for this.I also used the
default-membersfeature of Cargo to remove the need for specific package flags in the CI tests, making getting up and running with RustPython simpler (for me at least!)