feat: support for BOM POM's i.e. maven dependencyManagement #673
+92
−21
Conversation
maxandersen
force-pushed the
maxandersen:bompoms
branch
4 times, most recently
from
0254568
to
147ba33
jbang will now if and only if the very first dependency has a `@pom` classifier, download it and load it as pom file in shrinkwrap. Example: ```java //DEPS io.quarkus:quarkus-bom:1.11.0.Final@pom //DEPS io.quarkus:quarkus-resteasy //DEPS io.quarkus:quarkus-smallrye-openapi //DEPS io.quarkus:quarkus-swagger-ui ``` Then that pom file dependency management (and dependencies) gets listened to. Fixes #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jbang will now if and only if the very first dependency has a
@pomclassifier, download it and load it as pom file in shrinkwrap.
Example:
Then that pom file dependency management (and dependencies) gets listened to.
Fixes #63
Caveats:
a way to do that with shrinkwrap; we could potentially if more than one found generate
a temporary one that has them all listed (TBD)
Should add check that for now is only one @pom and reject otherwise we risk breaking users in future when we have it.
Could probably find a way to call maven directly to get it but for now this is what we got :)