Skip to content

fix(@ngtools/webpack): recover from component stylesheet errors#19899

Merged
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:ngtools/css-error
Feb 2, 2021
Merged

fix(@ngtools/webpack): recover from component stylesheet errors#19899
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:ngtools/css-error

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

Webpack doesn't handle well expections and promise rejections. With this change we use the compilation errors.

Closes #19892

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 29, 2021
@google-cla google-cla Bot added the cla: yes label Jan 29, 2021
@alan-agius4 alan-agius4 requested a review from clydin January 29, 2021 11:34
Webpack doesn't handle well expections and promise rejections. With this change we use the compilation errors.

Closes #19892
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 2, 2021
@alan-agius4 alan-agius4 merged commit e1efc35 into angular:master Feb 2, 2021
@alan-agius4 alan-agius4 deleted the ngtools/css-error branch February 2, 2021 15:54
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v11.1 build still crashes sometimes when error in scss file

2 participants