Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.x] Revert "stream: fix .end() error propagation" #37060

Closed
wants to merge 1 commit into from
Closed

[15.x] Revert "stream: fix .end() error propagation" #37060

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jan 25, 2021

This reverts commit 4c819d6.

Fixes #37027

@mcollina
Copy link
Member Author

@mcollina mcollina commented Jan 25, 2021

cc @lpinca @danielleadams

lpinca
lpinca approved these changes Jan 25, 2021
View changes
@mcollina mcollina requested review from ronag and dnlup Jan 25, 2021
dnlup
dnlup approved these changes Jan 25, 2021
View changes
ronag
ronag approved these changes Jan 25, 2021
View changes
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jan 25, 2021 •
edited by BethGriggs

CI: https://ci.nodejs.org/job/node-test-pull-request/35722/ ✅

Trott
Trott approved these changes Jan 31, 2021
View changes
@Trott
Copy link
Member

@Trott Trott commented Jan 31, 2021

We should probably add a test for #37027. (Doesn't have to be here/now, though.)

@Trott
Copy link
Member

@Trott Trott commented Jan 31, 2021

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?

@ronag
Copy link
Member

@ronag ronag commented Jan 31, 2021

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?

Revert on 15 leave on master

@jasnell jasnell changed the title Revert "stream: fix .end() error propagation" [15.x] Revert "stream: fix .end() error propagation" Feb 1, 2021
@danielleadams
Copy link
Member

@danielleadams danielleadams commented Feb 15, 2021

Landed in d2a487e

danielleadams added a commit that referenced this issue Feb 15, 2021
@mcollina @danielleadams
Revert "stream: fix .end() error propagation"
d2a487e 
This reverts commit 4c819d6.

PR-URL: #37060
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@mcollina mcollina closed this Feb 15, 2021
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
Closed
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
Merged
@lpinca lpinca mentioned this pull request Mar 5, 2021
Closed
@mcollina mcollina deleted the revert-36817-v15 branch Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@lpinca lpinca

@ronag ronag

@danielleadams danielleadams

@BethGriggs BethGriggs

@dnlup dnlup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
8 participants
@mcollina @nodejs-github-bot @Trott @ronag @danielleadams @lpinca @BethGriggs @dnlup