Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use client agnostic command names #105

Open
fbricon opened this issue Nov 14, 2017 · 1 comment
Open

Use client agnostic command names #105

fbricon opened this issue Nov 14, 2017 · 1 comment
Milestone

Comments

@fbricon
Copy link
Collaborator

@fbricon fbricon commented Nov 14, 2017

From eclipse/eclipse.jdt.ls#424 (comment), I noticed the debugger exposes vscode* commands on the server side.

[Trace - 21:52:28] Received request 'client/registerCapability - (5)'.
Params: {
    "registrations": [
        {
            "id": "18163e21-97e7-4ae8-b51c-5cdb20e639b1",
            "method": "workspace/executeCommand",
            "registerOptions": {
                "commands": [
                    "java.edit.organizeImports",
                    "vscode.java.fetchUsageData",
                    "vscode.java.resolveClasspath",
                    "vscode.java.resolveMainClass",
                    "vscode.java.updateDebugSettings",
                    "vscode.java.buildWorkspace",
                    "vscode.java.startDebugSession"
                ]
            }
        }
    ]

It'd be better if the names were client agnostic.

@andxu andxu added this to the 0.5.0 milestone Nov 28, 2017
@andxu
Copy link
Collaborator

@andxu andxu commented Nov 28, 2017

we will change the command name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.