Skip to content

/ superset

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chart]rich tooltip text overflows outside of the parent div for line chart #12688

Open
bryanck opened this issue Jan 22, 2021 · 2 comments
Open

[chart]rich tooltip text overflows outside of the parent div for line chart #12688

bryanck opened this issue Jan 22, 2021 · 2 comments
Labels
good first issue need:more-info viz:chart-multiline

Comments

@bryanck
Copy link
Contributor

@bryanck bryanck commented Jan 22, 2021 •
edited

Screenshot

Screen Shot 2021-01-22 at 7 01 01 AM

Description

The rich tooltip text renders in a table that is inside a parent div that has the max-width set. If the text in the table is too wide, then the text will render outside of the div.

This is being caused by this line setting the max width of the div:
https://github.com/apache-superset/superset-ui/blob/b7a2f5241b56ff78dfb3f53105383fc40b12e0e9/plugins/legacy-preset-chart-nvd3/src/utils.js#L317

You can reproduce this by creating a multiline chart, group by a field with longer strings, and then reducing the width of the chart by resizing your browser window.
@junlincc junlincc changed the title bug: rich tooltip text overflows outside of the parent div for line chart [chart]rich tooltip text overflows outside of the parent div for line chart Jan 22, 2021
@junlincc
Copy link
Contributor

@junlincc junlincc commented Jan 22, 2021 •
edited

@bryanck hey, thanks for reporting issues lately! do you minding include Superset version? this looks like a good first issue, lmk if you would like to work on it. :) 🙏
@bryanck
Copy link
Contributor Author

@bryanck bryanck commented Jan 22, 2021

This is version 1.0. I can create a PR in superset-ui. I was thinking to remove the max-width setting, which does resolve this.
@bryanck bryanck mentioned this issue Jan 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue need:more-info viz:chart-multiline
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bryanck @junlincc