bpo-42916: detect dicom files #24227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @serhiy-storchaka, @berkerpeksag, looks like you two were the last contributors to the affected files. Either of you happy to review these changes for me please? |
|
Hi @PCManticore, looks like you were one of the most recent contributors to the imghdr module. Would you mind reviewing these changes for me please? |
|
I think DICOM is too specific to be added to the stdlib. I'd prefer improving documentation of imghdr.tests to make adding custom file types clearer. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing this PR: it's been stale for over six months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect DICOM file format in
imghdr.py.https://bugs.python.org/issue42916