Snapshot singleton clone deep #1148
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Additional container option for a cloneDeep function that ensures that when snapshot and restore the cached value is restored to its former state respecting singleton scope.
Related Issue
#715
Note that constant value ( non function ) is also cloned.
Motivation and Context
#715
How Has This Been Tested?
TDD.
Note
Because of this._bindingDictionary = new Lookup<interfaces.Binding>(); the _singletonCloneDeep property of the Binding implementation has had to go on the interface as well.
If you are happy with the lodash cloneDeep js being copied into the repository I will do so.
Types of changes
Checklist: