Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot singleton clone deep #1148

Open
wants to merge 4 commits into
base: master
from

Conversation

@tonyhallett
Copy link

@tonyhallett tonyhallett commented Sep 6, 2019

Description

Additional container option for a cloneDeep function that ensures that when snapshot and restore the cached value is restored to its former state respecting singleton scope.

Related Issue

#715

Note that constant value ( non function ) is also cloned.

Motivation and Context

#715

How Has This Been Tested?

TDD.

Note

Because of this._bindingDictionary = new Lookup<interfaces.Binding>(); the _singletonCloneDeep property of the Binding implementation has had to go on the interface as well.

If you are happy with the lodash cloneDeep js being copied into the repository I will do so.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.
parisholley and others added 4 commits Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.