Binding.implementation ts correction #1127
Open
Conversation
…nto Binding.implementation_ts_correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
This is being picky but for correctness. For the generic T to be correct the implementationType type has to change otherwise T will be incorrect for cache/onActivation when toConstructor has been used to set the Binding.
Related Issue
Motivation and Context
It corrects the typescript - e.g no need for the BindingToSyntax to cast to any when setting the implementationType in the toConstructor method.
How Has This Been Tested?
npm run test on Windows machine
Types of changes
Yes if using the Binding.implementationType.
Checklist:
No new tests required