Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide option to default to github provider for git.api.getRemoteSources #106368

Merged
merged 3 commits into from Nov 10, 2020
Merged

Provide option to default to github provider for git.api.getRemoteSources #106368

merged 3 commits into from Nov 10, 2020

Conversation

wangjaso
Copy link
Contributor

@wangjaso wangjaso commented Sep 9, 2020

This PR fixes #106316

@joaomoreno

Add an optional param to the git.api.getRemoteSources api call to default to a specific provider.

You can test it by calling

await commands.executeCommand('git.api.getRemoteSources', {
    providerName: 'GitHub'
})

This will skip the choose provider and show directly your repos in GitHub

joaomoreno
joaomoreno requested changes Sep 10, 2020
View changes
extensions/git/src/remoteSource.ts Outdated Show resolved Hide resolved
@wangjaso
Copy link
Contributor Author

wangjaso commented Sep 11, 2020

Let me know if there's anything else to be fixed here. Thanks!

@wangjaso
Copy link
Contributor Author

wangjaso commented Sep 17, 2020

@joaomoreno Can this change be merged now?

@joaomoreno joaomoreno added this to the October 2020 milestone Sep 28, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Nov 10, 2020

Thanks! 🍻

@joaomoreno joaomoreno merged commit 7200f73 into microsoft:master Nov 10, 2020
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

Provide option to default to github provider git.api.getRemoteSources and potentially list org repos.
3 participants
@wangjaso @joaomoreno @JacksonKearl