Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regularize logging #2819

Merged
merged 3 commits into from Sep 25, 2020
Merged

Regularize logging #2819

merged 3 commits into from Sep 25, 2020

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Sep 17, 2020

This PR:

  • regularizes logging calls and adds a spec in CONTRIBUTING
  • fix how the default stream handler is loaded to not override a logging level set by the user before Scapy's load.
  • turns some warnings logs in DeprecationWarnings

@gpotter2 gpotter2 added the cleanup label Sep 17, 2020
@gpotter2 gpotter2 force-pushed the logging branch 4 times, most recently from 413d259 to 7d3ccda Compare Sep 17, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 17, 2020 •
edited

Codecov Report

Merging #2819 into master will increase coverage by 0.35%.
The diff coverage is 60.43%.

@@            Coverage Diff             @@
##           master    #2819      +/-   ##
==========================================
+ Coverage   87.82%   88.17%   +0.35%     
==========================================
  Files         254      254              
  Lines       54004    54009       +5     
==========================================
+ Hits        47430    47624     +194     
+ Misses       6574     6385     -189
Impacted Files Coverage Δ
scapy/plist.py 87.27% <ø> (+0.19%) ⬆️
scapy/route.py 92.18% <0.00%> (ø)
scapy/arch/windows/__init__.py 68.50% <14.28%> (-0.12%) ⬇️
scapy/arch/libpcap.py 82.03% <20.00%> (ø)
scapy/arch/unix.py 76.01% <20.00%> (ø)
scapy/fields.py 92.52% <50.00%> (+0.12%) ⬆️
scapy/layers/inet.py 74.13% <50.00%> (ø)
scapy/layers/inet6.py 88.42% <50.00%> (ø)
scapy/utils.py 80.86% <50.00%> (+0.34%) ⬆️
scapy/layers/dns.py 93.43% <54.54%> (+0.01%) ⬆️
... and 26 more

@gpotter2 gpotter2 force-pushed the logging branch 2 times, most recently from d762b33 to 31e071c Compare Sep 19, 2020
guedou
guedou previously approved these changes Sep 20, 2020
View changes
Copy link
Member

@guedou guedou left a comment

Cool PR! I like the changes that you did to the messages levels.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
doc/scapy/extending.rst Outdated Show resolved Hide resolved
scapy/arch/windows/__init__.py Outdated Show resolved Hide resolved
scapy/arch/windows/__init__.py Outdated Show resolved Hide resolved
scapy/arch/windows/__init__.py Outdated Show resolved Hide resolved
scapy/arch/windows/__init__.py Outdated Show resolved Hide resolved
scapy/route.py Outdated Show resolved Hide resolved
scapy/error.py Outdated Show resolved Hide resolved
scapy/error.py Outdated Show resolved Hide resolved
@guedou
Copy link
Member

@guedou guedou commented Sep 21, 2020

Thanks for your modifications! It is ready to be merged.

@gpotter2
Copy link
Member Author

@gpotter2 gpotter2 commented Sep 23, 2020

I'd like to have #2671 merged any other of my PRs to make sure it doesn't break.

@gpotter2 gpotter2 merged commit 9a9853f into secdev:master Sep 25, 2020
16 checks passed
@gpotter2 gpotter2 deleted the logging branch Sep 25, 2020
akorb pushed a commit to akorb/scapy that referenced this issue Sep 28, 2020
@gpotter2 @akorb
Regularize logging (secdev#2819)
6491307 
* Improvements to Scapy's logging

* Throw deprecation warnings when necessary

* Regularize logging in Scapy
akorb pushed a commit to akorb/scapy that referenced this issue Oct 5, 2020
@gpotter2 @akorb
Regularize logging (secdev#2819)
d1dc97d 
* Improvements to Scapy's logging

* Throw deprecation warnings when necessary

* Regularize logging in Scapy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guedou guedou

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gpotter2 @guedou