Skip to content

/ rules_python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for `python_requires` to wheel #378

Closed
AutomatedTester opened this issue Nov 11, 2020 · 0 comments
Closed

Add support for `python_requires` to wheel #378

AutomatedTester opened this issue Nov 11, 2020 · 0 comments

Comments

@AutomatedTester
Copy link
Contributor

@AutomatedTester AutomatedTester commented Nov 11, 2020

🚀 feature request

Relevant Rules

py_wheel needs to grow this feature

Description

A clear and concise description of the problem or missing capability...

Python wheel rule doesn't have the ability to specify python_requires which can cause issues if the wrong version of python installs the wheel

see https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires

Describe the solution you'd like

Ideally I can just extend the signature to add an optional field for this,

Describe alternatives you've considered

No because I couldn't find any
@AutomatedTester AutomatedTester mentioned this issue Nov 11, 2020
Closed
AutomatedTester added a commit to AutomatedTester/rules_python that referenced this issue Nov 11, 2020
@AutomatedTester
Adds the "Requires-Python" metadata support. Fixes bazelbuild#378
bb543a3 
This adds support for allowing people to specify which versions
of python a wheel should run on. This was added in PEP 440
@AutomatedTester AutomatedTester mentioned this issue Nov 11, 2020
Merged
3 of 13 tasks complete
@AutomatedTester AutomatedTester changed the title Add support for `python_requires` to wheen Add support for `python_requires` to wheel Nov 12, 2020
@alexeagle alexeagle closed this in aa27a3f Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@AutomatedTester
You can’t perform that action at this time.