AssemblyScript / node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Implement] Buffer#inspect #15

Open

jtenner wants to merge 17 commits into master from inspect

Collaborator

jtenner commented Jul 22, 2019

No description provided.


          [Implement] Buffer#concat (todo: fix tlsf problem)

99b14a8

jtenner requested a review from dcodeIO

jtenner self-assigned this

jtenner changed the title ~~[Implement] Buffer#concat (todo: fix tlsf problem)~~ [Implement] Buffer#inspect (todo: fix tlsf problem)

jtenner added 2 commits


          [Fix] Clean up inspect implementation


          [Fix] Edge case when length = 0, todo: more optimization

01d079b

Collaborator Author

jtenner commented Jul 23, 2019

@dcodeIO I think this could probably be optimized further but I've hit my limit. Any thoughts?

jtenner added 2 commits


          [Chore] switch to global

10a5c54


          [Chore] Merge master

fe0cf50

jtenner changed the title ~~[Implement] Buffer#inspect (todo: fix tlsf problem)~~ [Implement] Buffer#inspect


          [Optimize] memory.copy parameters with global strings

f418fd0

jtenner added the enhancement label


          [Merge] master, use Hex encoding method

cea7473

Collaborator Author

jtenner commented Aug 1, 2019

This method is the reason why I created the charsFromByte() method. Now we can re-use it here in the .inspect() method.

All set for review @dcodeIO

MaxGraey reviewed

assembly/buffer/index.ts Outdated Show resolved Hide resolved

jtenner added 5 commits


          Merge branch 'master' into inspect

e5f6e4a


          [Fix] switch to hex

628562c


          [Fix] types merge problem

b956d5e


          [fix] example

e8afe85


          [chore] remove unecessary comment

b9ed343

MaxGraey reviewed

assembly/buffer/index.ts Outdated Show resolved Hide resolved

jtenner added 5 commits


          [fix] nit remove parenthesis

a5579cb


          [fix] remove type annotation

11cc4d3


          [test] use create convenience method instead

a00145c


          [fix] switch to known constant

ef7e34e


          [fix] add BUFFER_INSPECT_HEADER_BYTE_LEN constant

5fe8a7f

Collaborator Author

jtenner commented Mar 13, 2020

Using the new __aspectReflectAs() api, we can log(new ArrayBuffer()) with the inspect output just like node.js outputs Buffers. Will have to revisit this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.