Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript definition test #92

Merged
merged 1 commit into from Nov 15, 2017
Merged

typescript definition test #92

merged 1 commit into from Nov 15, 2017

Conversation

@ghost
Copy link

@ghost ghost commented Nov 13, 2017

This PR mainly adds TypeScript definition tests to test the definitions from index.d.ts. It is taken from DefinitelyTyped as well as the index.d.ts.

Also i took the liberty to add some devDependencies and the package-lock.jsongenerated by npm and is encouraged is to put under version control.

* added typescript-compile to tests
* added types to packate.json
* added package-lock.json
@coveralls
Copy link

@coveralls coveralls commented Nov 13, 2017

Coverage Status

Coverage remained the same at 98.503% when pulling d812604 on useltmann:master into 69ca541 on mpneuried:master.

@mpneuried
Copy link
Contributor

@mpneuried mpneuried commented Nov 15, 2017

Thanks for this work on the typescript definitions!

@mpneuried mpneuried merged commit 9cf4ddb into node-cache:master Nov 15, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.503%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.