Skip to content

/ node-cache

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds option to prevent autoremove variable on expiry #90

Merged
merged 2 commits into from Nov 10, 2017
Merged

adds option to prevent autoremove variable on expiry #90

merged 2 commits into from Nov 10, 2017

Conversation

@ghost
Copy link

@ghost ghost commented Aug 21, 2017

refs #87:

  • added new init-option deleteOnExpire
  • deletes a variable automatically only if deleteOnExpire is true

please review line 314-315, they seem dedundant by _check()
Ulf Seltmann
refs #87:
Loading status checks…
e6d9fd6 
* added new init-option `deleteOnExpire`
* deletes a variable automatically only if `deleteOnExpire` is true

please review line 314-315, they seem dedundant by _check()
@coveralls
Copy link

@coveralls coveralls commented Aug 21, 2017 •
edited

Coverage Status

Coverage increased (+0.01%) to 98.503% when pulling e6d9fd6 on useltmann:master into 24480d0 on mpneuried:master.
Ulf Seltmann
added typoscript definition
Loading status checks…
53c8fbf
@coveralls
Copy link

@coveralls coveralls commented Nov 8, 2017 •
edited

Coverage Status

Coverage increased (+0.01%) to 98.503% when pulling 53c8fbf on useltmann:master into 24480d0 on mpneuried:master.
@mpneuried
Copy link
Contributor

@mpneuried mpneuried commented Nov 10, 2017

Thanks for this Contribution!
I had a quick look at it and it looks good.

Especially the ts definitions ;-)

It will be integrated into the next release 4.2.0.
@mpneuried mpneuried merged commit 69ca541 into node-cache:master Nov 10, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 98.503%
Details
@ghost
Copy link
Author

@ghost ghost commented Nov 13, 2017

Yeah, great. Thanks!
Credits for the ts definition go to @andy-ms and @dthunell. Its taken from DefinitelyTyped/DefinitelyTyped with a view modifications by myself. I will try add the tests for the ts definition as well, but first i have to understand the concept of ts-definition tests.
@mpneuried mpneuried mentioned this pull request Nov 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@coveralls @mpneuried
You can’t perform that action at this time.