Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODE_OF_CONDUCT.md #40033

Merged

Conversation

@AbdulBaseerMohammedKhan
Copy link
Contributor

@AbdulBaseerMohammedKhan AbdulBaseerMohammedKhan commented May 31, 2020

No description provided.

@googlebot
Copy link

@googlebot googlebot commented May 31, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AbdulBaseerMohammedKhan
Copy link
Contributor Author

@AbdulBaseerMohammedKhan AbdulBaseerMohammedKhan commented May 31, 2020

@googlebot I signed it!

@googlebot
Copy link

@googlebot googlebot commented May 31, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gbaned gbaned self-assigned this Jun 1, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 1, 2020
@gbaned gbaned requested a review from mihaimaruseac Jun 1, 2020
@mihaimaruseac
Copy link
Collaborator

@mihaimaruseac mihaimaruseac commented Jun 1, 2020

Can you add a few more spelling fixes to this PR? We should not run multiple hours of CI for just a single word change

@AbdulBaseerMohammedKhan
Copy link
Contributor Author

@AbdulBaseerMohammedKhan AbdulBaseerMohammedKhan commented Jun 1, 2020

That was it
there aren't any more

@kyscg
Copy link
Contributor

@kyscg kyscg commented Jun 2, 2020

From CONTRIBUTING.md,

As every PR requires several CPU/GPU hours of CI testing, we discourage submitting PRs to fix one typo, one warning,etc. We recommend fixing the same issue at the file level at least (e.g.: fix all typos in a file, fix all compiler warning in a file, etc.)

@mihaimaruseac
Copy link
Collaborator

@mihaimaruseac mihaimaruseac commented Jun 2, 2020

Please look in other files too, in that case

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jun 4, 2020
@kyscg
Copy link
Contributor

@kyscg kyscg commented Jun 4, 2020

Good catches!! Thanks for your contribution

@rthadur
rthadur approved these changes Jun 5, 2020
@tensorflow-copybara tensorflow-copybara merged commit 9244dd5 into tensorflow:master Jun 5, 2020
7 of 10 checks passed
7 of 10 checks passed
MacOS CPU Python3 Internal CI build started.
Details
MacOS Python2 and CC Internal CI build started.
Details
Windows Bazel GPU Internal CI build started.
Details
Android Demo App Internal CI build successful
Details
Linux GPU Internal CI build successful
Details
Ubuntu CPU Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Windows Bazel Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Queue
  
Approved by Reviewer
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.