Add Fable #2043
Merged
Add Fable #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyonj
requested changes
Dec 21, 2020
Contributor
kenyonj
left a comment
kenyonj
left a comment
There was a problem hiding this comment.
Looks like you need to update the image to be the correct dimensions:
topics::fable topic#test_0019_has at most one image with the right name, type, and dimensions [/home/runner/work/explore/explore/test/topics_test.rb:229]:
topic images should be 288px wide.
Expected: 288
Actual: 2458
kenyonj
approved these changes
Dec 23, 2020
Contributor
kenyonj
left a comment
kenyonj
left a comment
There was a problem hiding this comment.
💯 🍨 Thank you for your contribution! I'll merge this in as soon as CI is 🍏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing! Please confirm this pull request meets the following requirements:
Which change are you proposing?
Curating a new topic or collection
https://github.com/topics/[NAME]orhttps://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docsFable is arguably one of the most popular F# OSS libraries, and there are many other things out there that are related to it and use its topic tag.