I wonder how can we pass that via pytest?

I think we could set Tox’s install_command for jobs running the latest versions of everything. If there’s a failure, the whole job would fail. So, if it does not, we are OK.

Hi there, first time contributing for scrapy :) (Also, first time handling tox)

I have set install_command on PR as suggested above. Seems like Azure Pipelines fails on py36. Logs shows that it failed on installing conflicting dependencies, and I'm not sure how to approach this one.

Travis seems to use older version of pip (<20.2) . Would having travis use newer version of pip problematic?

Thanks for taking this up!

Seems like Azure Pipelines fails on py36. Logs shows that it failed on installing conflicting dependencies, and I'm not sure how to approach this one.

I think the way to go is to upgrade the version of cryptography we use in test jobs with pinned versions to 2.1.4. See the [pinned] section of tox.ini. I would also include a comment indicating why we are upgrading (required by mitmproxy, which is a test dependency), because all other pinned versions there come from setup.py).

Travis seems to use older version of pip (<20.2) . Would having travis use newer version of pip problematic?

I think that should be fine, and it seems doable.

By the way, my original idea was to have a single job use this, but seeing how by enabling this in all jobs you found an issue in a job that might have gone undetected otherwise, I think it makes sense to use this feature in all jobs.

By the way, my original idea was to have a single job use this, but seeing how by enabling this in all jobs you found an issue in a job that might have gone undetected otherwise, I think it makes sense to use this feature in all jobs.

You're right, clumsy me!

I think that should be fine, and it seems doable.

Travis seems to be a pain for upgrading pip. The one posted in the link does not work and putting it in before_install does not seem to change much. Not sure about this, but probably it's because of pip on travis cache?

Also, on py36, the dependencies keep conflicting. I was wondering if loosening the range of dep versions for test job would be wise?

I've forgot again how do we use the pinned env :) As the proposed change modifies the versions there.

I've forgot again how do we use the pinned env :) As the proposed change modifies the versions there.

I genuinely forgot the env was supposed to be pinned due to the whole travis thing. Thanks for pointing that out.

Let’s continue the conversation on the PR, it should make it easier to give feedback specific to it.