Skip to content

/ pytorch

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace blacklist/whitelist in test/backward_compatibility/check_backward_compatibility.py #41750

Open
SplitInfinity opened this issue Jul 20, 2020 · 5 comments
Open

Replace blacklist/whitelist in test/backward_compatibility/check_backward_compatibility.py #41750

SplitInfinity opened this issue Jul 20, 2020 · 5 comments
Labels
better-engineering good first issue triaged

Comments

@SplitInfinity
Copy link
Contributor

@SplitInfinity SplitInfinity commented Jul 20, 2020

The goal of this issue is to replace all instances of whitelist and blacklist in test/backward_compatibility/check_backward_compatibility.py. See issue #41443 for more information.
@SplitInfinity SplitInfinity mentioned this issue Jul 20, 2020
Open
50 of 64 tasks complete
@nomanarshad94
Copy link

@nomanarshad94 nomanarshad94 commented Jul 24, 2020

Working on this issue to replace all instances of blacklist or whitelist from test/backward_compatibility/check_backward_compatibility.py to blocklist or allowlist respectively.
@nomanarshad94
Copy link

@nomanarshad94 nomanarshad94 commented Jul 24, 2020

Opened pull request for a quick fix.
@SplitInfinity
Copy link
Contributor Author

@SplitInfinity SplitInfinity commented Jul 24, 2020

Can you link the pull request to this issue?
@nomanarshad94
Copy link

@nomanarshad94 nomanarshad94 commented Jul 24, 2020 •
edited

Pull request:
fixed: #41972
@nomanarshad94 nomanarshad94 mentioned this issue Jul 24, 2020
Closed
@SplitInfinity SplitInfinity mentioned this issue Jul 27, 2020
Closed
@SplitInfinity
Copy link
Contributor Author

@SplitInfinity SplitInfinity commented Jul 27, 2020

Fixed by #41733.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better-engineering good first issue triaged
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Replaced all instances of blacklist or whitelist appropriately
2 participants
@SplitInfinity @nomanarshad94
You can’t perform that action at this time.