Skip to content

/ OpenRCT2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FileScanner::ScanDirectory return a unique_ptr instead of a raw one #13445

Open
tupaschoal opened this issue Nov 23, 2020 · 0 comments
Open

Make FileScanner::ScanDirectory return a unique_ptr instead of a raw one #13445

tupaschoal opened this issue Nov 23, 2020 · 0 comments
Labels
good first issue refactor

Comments

@tupaschoal
Copy link
Member

@tupaschoal tupaschoal commented Nov 23, 2020

The ScanDirectory method of FileScanner allocates pointers with new and returns raw pointers. It should use unique_ptr instead.

Note: Wait for #13444 resolution before working on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@tupaschoal
You can’t perform that action at this time.