New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CA1309: Use ordinal StringComparison in CertificateProvider #14352

Merged

iSazonov merged 2 commits into PowerShell:master from xtqqczze:CA1309-p1

Jun 25, 2021

Contributor

xtqqczze commented Dec 8, 2020

Non-breaking change, just makes existing behaviour explicit.

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1309

xtqqczze added 2 commits


          Fix CA1309: Use ordinal StringComparison

ae2aac5

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1309


          Fix wrapping

d78c7ad

msftbot bot assigned iSazonov

iSazonov reviewed

src/Microsoft.PowerShell.Security/security/CertificateProvider.cs Show resolved Hide resolved

iSazonov assigned TravisEz13 and unassigned iSazonov

iSazonov added the CL-CodeCleanup label

msftbot bot added the Review - Needed label

msftbot bot commented Dec 18, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

xtqqczze closed this

xtqqczze reopened this

xtqqczze closed this

xtqqczze reopened this

iSazonov requested review from PaulHigin and TravisEz13

iSazonov approved these changes

PaulHigin approved these changes

Collaborator

PaulHigin left a comment

According to the documentation, the default string compare is ordinal. But I think it makes sense to explicitly set the Comparer to make intention clear.

xtqqczze closed this

xtqqczze reopened this

vexx32 approved these changes

iSazonov merged commit a3366b8 into PowerShell:master

37 checks passed

msftbot bot removed the Review - Needed label

iSazonov added this to the 7.2.0-preview.8 milestone

xtqqczze deleted the CA1309-p1 branch

Contributor Author

xtqqczze commented Jun 25, 2021

Contributes to #15669.

msftbot bot commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.🎉

Handy links:

Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment