Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Fix a few margins due to bad markup #23619

Merged
merged 7 commits into from Dec 17, 2020
Merged

[doc] Fix a few margins due to bad markup #23619

merged 7 commits into from Dec 17, 2020

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Dec 2, 2020 •
edited by miss-islington

Automerge-Triggered-By: GH:Mariatta

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 2, 2020
vsajip
vsajip reviewed Dec 3, 2020
View changes
Copy link
Member

@vsajip vsajip left a comment

I'm happy with the changes to logging.config.rst.

@andresdelfino andresdelfino mentioned this pull request Dec 4, 2020
Closed
Mariatta
Mariatta approved these changes Dec 17, 2020
View changes
Copy link
Sponsor Member

@Mariatta Mariatta left a comment

Thanks!

@Mariatta Mariatta added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 17, 2020
@miss-islington miss-islington merged commit 96a09df into python:master Dec 17, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Dec 17, 2020

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Dec 17, 2020

Sorry, @andresdelfino, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 96a09df64483b70c4215c7025a19b9d2f1636c55 3.9

@miss-islington miss-islington self-assigned this Dec 17, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Dec 17, 2020

Sorry @andresdelfino, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 96a09df64483b70c4215c7025a19b9d2f1636c55 3.8

@andresdelfino andresdelfino deleted the fix_margins branch Dec 17, 2020
@andresdelfino
Copy link
Contributor Author

andresdelfino commented Dec 17, 2020

I'll work on the backports today.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 19, 2020
@andresdelfino
[3.9] [doc] Fix a few margins due to bad markup (pythonGH-23619).
1cdbfd3 
(cherry picked from commit 96a09df)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 19, 2020

GH-23859 is a backport of this pull request to the 3.9 branch.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 19, 2020
@andresdelfino
[3.8] [doc] Fix a few margins due to bad markup (pythonGH-23619).
316ca9b 
(cherry picked from commit 96a09df)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 19, 2020

GH-23860 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit that referenced this pull request Dec 22, 2020
@andresdelfino
[3.9] [doc] Fix a few margins due to bad markup (GH-23619). (GH-23859)
7c48859 
(cherry picked from commit 96a09df)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington pushed a commit that referenced this pull request Dec 22, 2020
@andresdelfino
[3.8] [doc] Fix a few margins due to bad markup (GH-23619). (GH-23860)
d3ab4c8 
(cherry picked from commit 96a09df)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
[doc] Fix a few margins due to bad markup (pythonGH-23619)
c7d9d37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

@Mariatta Mariatta

@ethanfurman ethanfurman

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andresdelfino @miss-islington @bedevere-bot @vsajip @Mariatta @the-knights-who-say-ni