Skip to content

/ flutter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageRouteBuilder takes some time to set `barrierColor`. #24469

Closed
nirav4273 opened this issue Nov 17, 2018 · 4 comments
Closed

PageRouteBuilder takes some time to set `barrierColor`. #24469

nirav4273 opened this issue Nov 17, 2018 · 4 comments
Labels
P4 f: routes found in release: 1.20 framework has reproducible steps

Comments

@nirav4273
Copy link

@nirav4273 nirav4273 commented Nov 17, 2018 •
edited by zoechi

barrierColor task some to set in PageRouteBuilder. Widget load before barrierColor.
I am used PageRouteBuilder with Navigator
Here is my code

          Navigator.of(context).push(PageRouteBuilder(
              opaque: false,
              barrierDismissible: true,
              barrierColor: Colors.white12,
              pageBuilder: (context,_,__){
                return Center(
                  child: Container(
                    height: 200.0,
                    width: 200.0,
                    decoration: BoxDecoration(
                      color: Colors.white,
                      borderRadius: BorderRadius.circular(5.0)
                    ),
                  )
                );
              }
          ))

ezgif com-video-to-gif

Flutter details

[√] Flutter (Channel beta, v0.11.3, on Microsoft Windows [Version 6.3.9600], locale en-IN)
    • Flutter version 0.11.3 at E:\Android\sdk\flutter
    • Framework revision 72bf075e8d (7 days ago), 2018-11-09 20:36:17 -0800
    • Engine revision 5646e86a6f
    • Dart version 2.1.0 (build 2.1.0-dev.9.3 9c07fb64c4)
@zoechi zoechi changed the title PageRouteBuilder task some time to set `barrierColor`. PageRouteBuilder takes some time to set `barrierColor`. Nov 19, 2018
@zoechi zoechi added this to the Goals milestone Nov 19, 2018
@zoechi
Copy link
Contributor

@zoechi zoechi commented Nov 19, 2018

Can you please add a self-contained running minimal example (lib/main.dart) that can just be copied into a new project and executed?
@nirav4273
Copy link
Author

@nirav4273 nirav4273 commented Nov 19, 2018 •
edited

@zoechi Here you can find code. Tried to reproduce issue as above image.
https://github.com/nirav4273/flutter-pageroutebuilder-issue/blob/master/lib/main.dart
@kf6gpe kf6gpe added the P4 label May 29, 2020
@DFelten
Copy link
Member

@DFelten DFelten commented Aug 12, 2020

Did you find a solution? The problem is still there. The content is visible before the barrier color is shown.
@Hixie Hixie removed this from the None. milestone Aug 17, 2020
@darshankawar
Copy link
Contributor

@darshankawar darshankawar commented Sep 1, 2020

Issue replicable on latest stable (1.20.2).

24469.mp4.zip

flutter doctor -v 
[✓] Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.2 19C57, locale en-US)
    • Flutter version 1.20.2 at
      /Users/deeptibelsare/Documents/Fluttersdk/flutter
    • Framework revision bbfbf1770c (3 weeks ago), 2020-08-13 08:33:09 -0700
    • Engine revision 9d5b21729f
    • Dart version 2.9.1

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/deeptibelsare/Library/Android/sdk
    • Platform android-30, build-tools 29.0.3
    • ANDROID_HOME = /Users/deeptibelsare/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/deeptibelsare/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit
      https://flutter.dev/docs/get-started/install/macos#android-setup for
      detailed instructions.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] Connected device (1 available)
    • SM A260G (mobile) • 5200763ebcfa861f • android-arm • Android 8.1.0 (API
      27)

! Doctor found issues in 1 category.
sysint64 added a commit to sysint64/flutter that referenced this issue Nov 3, 2020
@sysint64
fix flutter#24469
Verified
This commit was signed with a verified signature.
sysint64 Andrey Kabylin
GPG key ID: E03BD89AA4AF1E97 Learn about signing commits
b30eebc
@sysint64 sysint64 mentioned this issue Nov 3, 2020
Merged
sysint64 added a commit to sysint64/flutter that referenced this issue Nov 19, 2020
@sysint64
fix flutter#24469
Verified
This commit was signed with a verified signature.
sysint64 Andrey Kabylin
GPG key ID: E03BD89AA4AF1E97 Learn about signing commits
d3a56b4
sysint64 added a commit to sysint64/flutter that referenced this issue Nov 21, 2020
@sysint64
fix flutter#24469 and flutter#67354
Verified
This commit was signed with a verified signature.
sysint64 Andrey Kabylin
GPG key ID: E03BD89AA4AF1E97 Learn about signing commits
aeb34fa
sysint64 added a commit to sysint64/flutter that referenced this issue Nov 24, 2020
@sysint64
fix flutter#24469 and flutter#67354
Verified
This commit was signed with a verified signature.
sysint64 Andrey Kabylin
GPG key ID: E03BD89AA4AF1E97 Learn about signing commits
55210bd
sysint64 added a commit to sysint64/flutter that referenced this issue Nov 25, 2020
@sysint64
fix flutter#24469 and flutter#67354
Verified
This commit was signed with a verified signature.
sysint64 Andrey Kabylin
GPG key ID: E03BD89AA4AF1E97 Learn about signing commits
0ee68d5
sysint64 added a commit to sysint64/flutter that referenced this issue Nov 25, 2020
@sysint64
fix flutter#24469 and flutter#67354
Verified
This commit was signed with a verified signature.
sysint64 Andrey Kabylin
GPG key ID: E03BD89AA4AF1E97 Learn about signing commits
c57ee44
fluttergithubbot pushed a commit that referenced this issue Nov 25, 2020
@sysint64
fix #24469 and #67354 (#69668)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e118e1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4 f: routes found in release: 1.20 framework has reproducible steps
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix #24469, #67354
6 participants
@zoechi @Hixie @DFelten @kf6gpe @nirav4273 @darshankawar
You can’t perform that action at this time.