Created on 2020-10-19 20:58 by conchylicultor, last changed 2020-10-25 18:53 by jaraco.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 22976 | open | jaraco, 2020-10-25 18:50 | |
| Messages (3) | |||
|---|---|---|---|
| msg379016 - (view) | Author: conchylicultor (conchylicultor) * | Date: 2020-10-19 20:58 | |
The following code fail with zipfile.Path, but works with pathlib.Path:
```
path = path.joinpath().joinpath('other', 'other')
```
Zipfile: https://github.com/python/cpython/blob/95ad890a7b0341d8d2fde13f824bc24c65a8ece0/Lib/zipfile.py#L2363
```
def joinpath(self, add):
```
Pathlib: https://github.com/python/cpython/blob/95ad890a7b0341d8d2fde13f824bc24c65a8ece0/Lib/pathlib.py#L955
```
def joinpath(self, *args):
```
|
|||
| msg379124 - (view) | Author: Jason R. Coombs (jaraco) *  |
Date: 2020-10-20 13:15 | |
This sounds like a worthy improvement. Are you interested in preparing a patch? Would you consider contributing it to https://github.com/jaraco/zipp first? |
|||
| msg379597 - (view) | Author: Jason R. Coombs (jaraco) * |
Date: 2020-10-25 18:37 | |
This issue is fixed in zipp 3.4.0. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-10-25 18:53:16 | jaraco | set | stage: patch review -> commit review |
| 2020-10-25 18:50:01 | jaraco | set | keywords:
+ patch stage: backport needed -> patch review pull_requests: + pull_request21893 |
| 2020-10-25 18:37:08 | jaraco | set | assignee: jaraco messages: + msg379597 stage: backport needed |
| 2020-10-20 13:15:54 | jaraco | set | messages: + msg379124 |
| 2020-10-20 03:11:45 | xtreak | set | nosy:
+ jaraco |
| 2020-10-19 20:58:28 | conchylicultor | create | |