Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Python 3.8 #306

Merged
merged 6 commits into from Oct 17, 2019
Merged

Add Support for Python 3.8 #306

merged 6 commits into from Oct 17, 2019

Conversation

@duboviy
Copy link
Contributor

@duboviy duboviy commented Oct 17, 2019

No description provided.

duboviy added 3 commits Oct 17, 2019
@gyermolenko
Copy link
Contributor

@gyermolenko gyermolenko commented Oct 17, 2019

@duboviy
CI has failed.

Because it goes like this (and it is quite common practice among open-source projs):
travis -> tox testenv -> pytest

Your change fails because tox doesn't have corresponding env yet.
I think you could add env for 38 same as 37.

@duboviy
Copy link
Contributor Author

@duboviy duboviy commented Oct 17, 2019

@duboviy
CI has failed.

Because it goes like this (and it is quite common practice among open-source projs):
travis -> tox testenv -> pytest

Your change fails because tox doesn't have corresponding env yet.
I think you could add env for 38 same as 37.

Thanks a lot @gyermolenko ! I've tried it - works like a charm!

duboviy added 2 commits Oct 17, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 17, 2019

Codecov Report

Merging #306 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   32.82%   32.46%   -0.36%     
==========================================
  Files          42       42              
  Lines        1496     1534      +38     
==========================================
+ Hits          491      498       +7     
- Misses       1005     1036      +31
Impacted Files Coverage Δ
patterns/structural/mvc.py 0% <0%> (ø) ⬆️
...atterns/behavioral/chain_of_responsibility__py2.py 0% <0%> (ø) ⬆️
patterns/other/blackboard__py3.py 0% <0%> (ø) ⬆️
patterns/behavioral/catalog.py 0% <0%> (ø) ⬆️
patterns/behavioral/memento.py 0% <0%> (ø) ⬆️
patterns/structural/flyweight__py2.py 0% <0%> (ø) ⬆️
patterns/behavioral/registry__py3.py 0% <0%> (ø) ⬆️
patterns/behavioral/registry__py2.py 0% <0%> (ø) ⬆️
patterns/other/blackboard__py2.py 0% <0%> (ø) ⬆️
...atterns/behavioral/chain_of_responsibility__py3.py 0% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13574b...a916b09. Read the comment docs.

@faif faif merged commit 24c876d into faif:master Oct 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@duboviy duboviy deleted the duboviy:patch-1 branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.