Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'Translations' section to '7. Documenting Python' #391

Merged
merged 2 commits into from Jun 22, 2018
Merged

Added 'Translations' section to '7. Documenting Python' #391

merged 2 commits into from Jun 22, 2018

Conversation

@blossomica
Copy link
Contributor

@blossomica blossomica commented Jun 21, 2018

This is a fix for issue #389. Please feel free to let me know if any additional edits are needed.
@terryjreedy terryjreedy requested a review from JulienPalard Jun 21, 2018
@terryjreedy
terryjreedy reviewed Jun 21, 2018
View changes
documenting.rst Outdated
Translations
============

There are now several official documentation translations. See section :ref:`21.5. Documentation Translations <experts>` and :PEP:`545`.

This comment has been minimized.

Sign in to view
@terryjreedy

terryjreedy Jun 21, 2018
Member

This line needs to be split into two lines.

The purpose of this addition is to properly direct people interested in helping with translations, and to give the rest of us a place to refer such people to. I think the above should be followed by a link to the doc sig instead of leaving it buried in the PEP. But Julien should confirm that the PEP is up to date or not and otherwise decide what this section should contain.

This comment has been minimized.

Sign in to view
@blossomica

blossomica Jun 22, 2018
Author Contributor

Thanks for the review, @terryjreedy. I made some edits, based on your comments, feel free to let me know if you think there is anything else I should fix.
@blossomica
Added 'Translations' section to '7. Documenting Python'
Loading status checks…
b2129c5 
Added 'Translations' section to '7. Documenting Python'

Added 'Translations' section to '7. Documenting Python'
@blossomica blossomica force-pushed the blossomica:issue389 branch from 0245c1c to b2129c5 Jun 22, 2018
@JulienPalard
JulienPalard approved these changes Jun 22, 2018
View changes
Copy link
Member

@JulienPalard JulienPalard left a comment

LGTM
@brettcannon
Tweak some wording
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7240f00
@brettcannon brettcannon merged commit b29900d into python:master Jun 22, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Jun 22, 2018

Thanks!
@blossomica
Copy link
Contributor Author

@blossomica blossomica commented Jun 22, 2018

You're welcome!
@blossomica blossomica deleted the blossomica:issue389 branch Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

@JulienPalard JulienPalard

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@blossomica @brettcannon @JulienPalard @terryjreedy @the-knights-who-say-ni
You can’t perform that action at this time.