Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReturning a count from addN (#833) #834
Open
Conversation
| import warnings | ||
|
|
||
| from hashlib import md5 | ||
|
|
joernhees
Oct 28, 2018
Member
please keep commits concise, don't change random other things...
please keep commits concise, don't change random other things...
mwatts15
Oct 30, 2018
Author
Contributor
Fair enough. They are unused though.
Fair enough. They are unused though.
| ) | ||
| if triples_stored is None: | ||
| return -1 | ||
| return triples_stored |
joernhees
Oct 28, 2018
Member
hmm, this won't really work without also at least updating the store interface in store.py
also i'd prefer a simple return in front of the dispatch to store... i don't see how -1 is better than simply returning None
hmm, this won't really work without also at least updating the store interface in store.py
also i'd prefer a simple return in front of the dispatch to store... i don't see how -1 is better than simply returning None
mwatts15
Oct 30, 2018
Author
Contributor
You're correct. I don't actually recall why I went with -1.
The intention is to make it optional. I have added a flag member variable to indicate whether addN returns a count on a store I maintain, but I didn't see a reason to make it official interface.
You're correct. I don't actually recall why I went with -1.
The intention is to make it optional. I have added a flag member variable to indicate whether addN returns a count on a store I maintain, but I didn't see a reason to make it official interface.
|
Open/Close Travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.