Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainer Workflow: double clicking changed file should open a diff #626

Closed
tocsoft opened this issue Oct 24, 2016 · 4 comments
Closed

Maintainer Workflow: double clicking changed file should open a diff #626

tocsoft opened this issue Oct 24, 2016 · 4 comments

Comments

@tocsoft
Copy link
Contributor

@tocsoft tocsoft commented Oct 24, 2016

I would expect double clicking the file in the changed files tree to open the diff view for the change. (this would preferably work without the branch needing to be checked outbut if not checked out then both side of the diff should be readonly).

I would also expect a right click option to just open the file with out the diff (this should probably only be enabled if they have the branch checked out, or maybe enabled but with a prompt asking them for permission to check out the branch first.).

@grokys
Copy link
Contributor

@grokys grokys commented Oct 24, 2016

Yep, this is coming in a PR very soon ;) There's already a branch with the feature: grokys/maintainer-workflow-diff; it just needs updating with the changes made due to feedback on the main maintainer workflow PR and then reviewing.

@grokys
Copy link
Contributor

@grokys grokys commented Oct 24, 2016

@tocsoft see the PR #567 for details of what is still to come.

@tocsoft
Copy link
Contributor Author

@tocsoft tocsoft commented Oct 24, 2016

awesome 👍

woops - missed that list at the top of the PR, i'll stop pointing stuff out what your obviously tracking already then.

@grokys
Copy link
Contributor

@grokys grokys commented Oct 24, 2016

Not at all - it's good to have eyes on this, and you saved me filing the issue myself ;)

@paladique paladique added this to the Maintainer Workflow: The Road to MVP milestone Dec 6, 2016
@shana shana closed this in #637 Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.