Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded npm packages to latest and cached licenses #96

Open
wants to merge 1 commit into
base: main
from

Conversation

@guyarb
Copy link

@guyarb guyarb commented Nov 11, 2020

No description provided.

@guyarb
Copy link
Author

@guyarb guyarb commented Nov 11, 2020

@jclem

and please, after finishing that PR - can we release a new version?

@JJ
Copy link
Contributor

@JJ JJ commented Nov 17, 2020

Well, leaving it within v3 would help to not break existing builds... At the end of the day, there's nothing changing in the API. But I guess that's what you mean after all.

@guyarb
Copy link
Author

@guyarb guyarb commented Nov 17, 2020

Well, leaving it within v3 would help to not break existing builds... At the end of the day, there's nothing changing in the API. But I guess that's what you mean after all.

Of course, I meant to keep V3 pointed to the new master.
Thanks for the clarification

@JJ
Copy link
Contributor

@JJ JJ commented Nov 17, 2020

I wonder if it wouldn't make more sense to just fork this and start using forked versions?

@guyarb
Copy link
Author

@guyarb guyarb commented Nov 17, 2020

I wonder if it wouldn't make more sense to just fork this and start using forked versions?

I think not
It will be only a temporary workaround. The correct way is to wait (or ping @jclem somehow) for the fix to be in the master.

@jclem
Copy link
Collaborator

@jclem jclem commented Nov 17, 2020

@guyarb Can you provide a bit more context on what's being updated in your PR description? The latest release v3.0.1 has the required actions-core update, which should fix failing workflows. I've also released an update with the latest Octokit dependencies in v3.1.0.

@jclem jclem closed this Nov 17, 2020
@jclem jclem reopened this Nov 17, 2020
@jclem
Copy link
Collaborator

@jclem jclem commented Nov 17, 2020

My bad, meant to hit "Comment" and hit "Close with comment" on accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.