Skip to content

/ msgpack-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build.sbt #297

Merged
merged 1 commit into from Nov 21, 2015
Merged

fix build.sbt #297

merged 1 commit into from Nov 21, 2015

Conversation

@xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Nov 21, 2015

No description provided.

@xuwei-k
fix build.sbt
Loading status checks…
f90efe8
@xerial
Copy link
Member

@xerial xerial commented Nov 21, 2015

Could you explain why this change is necessary? It will help us to understand the intention of the change.

Thanks.
@xuwei-k
Copy link
Contributor Author

@xuwei-k xuwei-k commented Nov 21, 2015

without this fix, msgpackCore and msgpackJackson subprojects does not inculude top level settings (e.g. organization := "org.msgpack", autoScalaLibrary := false ...)

current msgpackCore pom.xml ( msgpack-core/target/scala-2.11/msgpack-core_2.11-0.7.2-SNAPSHOT.pom)

(incorrent groupId. unnecessary scala-library dependency)

<?xml version='1.0' encoding='UTF-8'?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
    <modelVersion>4.0.0</modelVersion>
    <groupId>msgpack-core</groupId>
    <artifactId>msgpack-core_2.11</artifactId>
    <packaging>jar</packaging>
    <description>Core library of the MessagePack for Java</description>
    <version>0.7.2-SNAPSHOT</version>
    <name>msgpack-core</name>
    <organization>
        <name>msgpack-core</name>
    </organization>
    <url>http://msgpack.org/</url>
    <licenses>
        <license>
            <name>Apache 2</name>
            <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
        </license>
    </licenses>
    <scm>
        <connection>scm:git:github.com/msgpack/msgpack-java.git</connection>
        <developerConnection>scm:git:git@github.com:msgpack/msgpack-java.git</developerConnection>
        <url>github.com/msgpack/msgpack-java.git</url>
    </scm>
    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    </properties>
    <developers>
        <developer>
            <id>frsyuki</id>
            <name>Sadayuki Furuhashi</name>
            <email>frsyuki@users.sourceforge.jp</email>
        </developer>
        <developer>
            <id>muga</id>
            <name>Muga Nishizawa</name>
            <email>muga.nishizawa@gmail.com</email>
        </developer>
        <developer>
            <id>oza</id>
            <name>Tsuyoshi Ozawa</name>
            <url>https://github.com/oza</url>
        </developer>
        <developer>
            <id>komamitsu</id>
            <name>Mitsunori Komatsu</name>
            <email>komamitsu@gmail.com</email>
        </developer>
        <developer>
            <id>xerial</id>
            <name>Taro L. Saito</name>
            <email>leo@xerial.org</email>
        </developer>
    </developers>
    <dependencies>
        <dependency>
            <groupId>org.scala-lang</groupId>
            <artifactId>scala-library</artifactId>
            <version>2.11.7</version>
        </dependency>
    </dependencies>
</project>

fixed pom.xml

<?xml version='1.0' encoding='UTF-8'?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
    <modelVersion>4.0.0</modelVersion>
    <groupId>org.msgpack</groupId>
    <artifactId>msgpack-core</artifactId>
    <packaging>jar</packaging>
    <description>Core library of the MessagePack for Java</description>
    <version>0.7.2-SNAPSHOT</version>
    <name>msgpack-core</name>
    <organization>
        <name>MessagePack</name>
        <url>http://msgpack.org/</url>
    </organization>
    <url>http://msgpack.org/</url>
    <licenses>
        <license>
            <name>Apache 2</name>
            <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
        </license>
    </licenses>
    <scm>
        <connection>scm:git:github.com/msgpack/msgpack-java.git</connection>
        <developerConnection>scm:git:git@github.com:msgpack/msgpack-java.git</developerConnection>
        <url>github.com/msgpack/msgpack-java.git</url>
    </scm>
    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    </properties>
    <developers>
        <developer>
            <id>frsyuki</id>
            <name>Sadayuki Furuhashi</name>
            <email>frsyuki@users.sourceforge.jp</email>
        </developer>
        <developer>
            <id>muga</id>
            <name>Muga Nishizawa</name>
            <email>muga.nishizawa@gmail.com</email>
        </developer>
        <developer>
            <id>oza</id>
            <name>Tsuyoshi Ozawa</name>
            <url>https://github.com/oza</url>
        </developer>
        <developer>
            <id>komamitsu</id>
            <name>Mitsunori Komatsu</name>
            <email>komamitsu@gmail.com</email>
        </developer>
        <developer>
            <id>xerial</id>
            <name>Taro L. Saito</name>
            <email>leo@xerial.org</email>
        </developer>
    </developers>
    <dependencies> </dependencies>
</project>
@xerial
Copy link
Member

@xerial xerial commented Nov 21, 2015

Thanks for the clarification. I appreciate it :)
xerial added a commit that referenced this pull request Nov 21, 2015
@xerial
Merge pull request #297 from xuwei-k/fix-build-sbt
Loading status checks…
b39672a 
fix build.sbt
@xerial xerial merged commit b39672a into msgpack:v07-develop Nov 21, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xuwei-k xuwei-k deleted the xuwei-k:fix-build-sbt branch Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@xuwei-k @xerial
You can’t perform that action at this time.