bpo-41462: add os.set_blocking() support for VxWorks RTOS#21713
Merged
Conversation
vstinner
reviewed
Dec 7, 2020
| _Py_set_blocking(int fd, int blocking) | ||
| { | ||
| #if defined(HAVE_SYS_IOCTL_H) && defined(FIONBIO) | ||
| #if defined(HAVE_SYS_IOCTL_H) && defined(FIONBIO) && !defined(__VXWORKS__) |
Member
There was a problem hiding this comment.
Please add a comment, something like:
// bpo-41462: On VxWorks, ioctl(FIONBIO) only works on sockets: use fcntl() instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VxWorks does have the <sys/ioctl.h> header file. In this header file FIONBIO is also defined but the FIONBIO request is only supported on socket fd. To set the blocking/non-blocking mode, fcntl is supposed to be used. VxWorks' file system can respond to the FCNTL request of ioctl.
https://bugs.python.org/issue41462