Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Import source module manifest without failing #95
Conversation
johlju
changed the title
|
@Jaykul when you have time, could you please review this PR? |
|
|
||
| # If we found more than one module info then something is wrong in the source folder. | ||
| if (@($ModuleInfo).Count -gt 1) { | ||
| throw ("Found multiple module manifest in the root of the path {0}." -f $ParameterValues["SourcePath"]) |
Jaykul
May 22, 2020
Member
This looks like it will break modules that currently work, if they have a Configuration.psd1 file or even a build.psd1 file
This looks like it will break modules that currently work, if they have a Configuration.psd1 file or even a build.psd1 file
|
Reopen to change to suggestion in issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes an issue that still exist when there is no build module manifest and the
SourcePathis a folder that does not contain the module name.Prior to this fix the build was successful if SourcePath was either
c:\source\ModuleNameorc:\source\ModuleName\source\ModuleName.psd1, but failed if SourcePath wasc:\source\s(and the module manifest was inc:\source\s\source\ModuleName.psd1. This is solved with this PR.This change is