Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
feat: remove duplicate emails ignoring case in Personalization #924
Conversation
|
The setters currently don't work for lists of strings or lists of tuples. Wasn't sure if they're needed for this feature, but let me know what you think of them and the expected behavior for if they're used. At the moment, this will raise an |
childish-sambino
changed the title
|
Generally this looks good, but doesn't work when using just the p = Personalization()
to_email = To('test+to@example.com', 'Example To Name 0')
p.add_to(to_email)
p.add_to(to_email)Since there are several ways of setting/adding emails to these fields, and each set would result in a call to @property
def tos(self):
return _get_unique_recipients(self._tos) |
thinkingserious
added
status: waiting for feedback
type: community enhancement
and removed
status: code review request
labels
Fixes #788
This removes duplicate emails on setting the Personalization object, ignoring case.