Skip to content

/ oppia

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prod validators to be split into individual validators #10415

Open
ankita240796 opened this issue Aug 22, 2020 · 46 comments
Open

Refactor prod validators to be split into individual validators #10415

ankita240796 opened this issue Aug 22, 2020 · 46 comments
Labels
SLoP-25 good first issue
Projects
Data handling

Comments

@ankita240796
Copy link
Contributor

@ankita240796 ankita240796 commented Aug 22, 2020 •
edited by DubeySandeep

Refactor prod_validators.py such that there is one validator module per model module in core/storage/.

List of model categories

TODO

  • exploration
  • feedback
  • subtopic

In progress

Done

Steps to refactor

  • Extract all the validators related to a given model type for example activity into a new file named as <model-type>_validators.py for example activity_validators.py from prod_validators.py. Make sure you name the validators file exactly as <folder-name-in-above-list>_validators.py
  • Extract all the test related to the model type from prod_validators_test.py to <model-type>_validators_test.py.
  • Clean up the unused imports from the new validators file and existing prod validators file.
  • Clean up the unused variables from the new validators file and existing prod validators file.
  • Fix the file overview to have the correct explanation and copyright year.

Example PR: #10416 #10360
@ankita240796
Copy link
Contributor Author

@ankita240796 ankita240796 commented Aug 22, 2020

@vojtechjelinek PTAL to confirm if this looks fine, Thanks!
@ankita240796 ankita240796 mentioned this issue Aug 24, 2020
Merged
4 of 4 tasks complete
ankita240796 added a commit that referenced this issue Aug 24, 2020
@ankita240796
Fixes part of #10415: Refactor activity validators (#10416)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cdcd030 
* Refactor activity validators

* Fix import

* Fix import

* Address review comments

* Fix braces
@DubeySandeep
Copy link
Member

@DubeySandeep DubeySandeep commented Sep 19, 2020

Assigning @savithakj to the opportunity module. (As per offline discussion.)
@savithakj savithakj mentioned this issue Sep 20, 2020
Merged
4 of 4 tasks complete
@vojtechjelinek vojtechjelinek added this to To do in Data handling Sep 23, 2020
seanlip pushed a commit that referenced this issue Sep 26, 2020
@savithakj
Fixes part of #10415: Refactor opportunity validators (#10735)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
13d3208 
* refractored oppportunity validators

* fixed linter error

* refractored oppportunity validators

* fixed linter error

* removed collection_models

* reverting local linter error based changes

* reverted local linter error changes
@rlhouser
Copy link
Contributor

@rlhouser rlhouser commented Sep 30, 2020

I would like to try to work on the classifier model; thanks. @ankita240796, @DubeySandeep
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Sep 30, 2020

@rlhouser I have assigned you
@sunny1401
Copy link
Contributor

@sunny1401 sunny1401 commented Sep 30, 2020

I would like to try to work on the recommendations model. Thanks @ankita240796 @DubeySandeep
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Oct 1, 2020

@sunny1401 I have assigned you.
@vcamari2-bit
Copy link

@vcamari2-bit vcamari2-bit commented Oct 1, 2020

Can I try to work on audit?
@EricZLou
Copy link
Contributor

@EricZLou EricZLou commented Oct 1, 2020

@sf11047 absolutely! Assigned the task to you. Let us know if you have any questions!
@EricZLou
Copy link
Contributor

@EricZLou EricZLou commented Oct 1, 2020

@vcamari2-bit sorry! Audit just got assigned -- do you want to take a stab at one of the other modules?
@vcamari2-bit
Copy link

@vcamari2-bit vcamari2-bit commented Oct 1, 2020

Sure. How about config or email?
@dchen97
Copy link
Contributor

@dchen97 dchen97 commented Oct 1, 2020 •
edited

@vcamari2-bit - Go for config!
@shujingl-2020
Copy link

@shujingl-2020 shujingl-2020 commented Oct 1, 2020 •
edited

Hi! I would like to work on the job module! As a part of GHC OSD
@EricZLou
Copy link
Contributor

@EricZLou EricZLou commented Oct 1, 2020

@shujingl-2020 awesome! Assigning you to the job module. DM me with questions!
@pseyla
Copy link

@pseyla pseyla commented Oct 1, 2020

Hi! Could I work on the email module?
@EricZLou
Copy link
Contributor

@EricZLou EricZLou commented Oct 1, 2020

@pseyla absolutely!
@Salset
Copy link

@Salset Salset commented Oct 1, 2020

Hey, can I work on the exploration module as part of GHC OSD?
@kiranmayee-dobbali
Copy link

@kiranmayee-dobbali kiranmayee-dobbali commented Oct 1, 2020

Hey, Can I get feedback module? I am a part of GHC OSD.
@ajin46
Copy link

@ajin46 ajin46 commented Oct 1, 2020

Hi, can I work on Suggestion as a part of GHC OSD?
@EricZLou
Copy link
Contributor

@EricZLou EricZLou commented Oct 1, 2020

@Salset @kiranmayee-dobbali @ajin46 yes yes and yes! Let us know if you have any questions
@rlhouser rlhouser mentioned this issue Oct 1, 2020
Closed
4 of 4 tasks complete
vcamari2-bit added a commit to vcamari2-bit/oppia that referenced this issue Oct 1, 2020
@vcamari2-bit
Update and rename prod_validators.py to prod_config_validator.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7a68c5b 
Overview

    This PR fixes or fixes part of oppia#10415.
    This PR does the following: Refactors config classifier validator to a separate file.
vcamari2-bit added a commit to vcamari2-bit/oppia that referenced this issue Oct 1, 2020
@vcamari2-bit
Update and rename prod_validators.py to prod_config_validator.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
1d7129f 
Overview

    This PR fixes or fixes part of oppia#10415.
    This PR does the following: Refactors config classifier validator to a separate file.
@jian-en jian-en mentioned this issue Oct 21, 2020
Closed
4 of 4 tasks complete
@JoelWee
Copy link

@JoelWee JoelWee commented Oct 23, 2020

Hi @vojtechjelinek, could I pick up "Question" validators? :)
JoelWee added a commit to JoelWee/oppia that referenced this issue Oct 23, 2020
@JoelWee
refactor oppia#10415: refactor out question_validators
7dad409
JoelWee added a commit to JoelWee/oppia that referenced this issue Oct 23, 2020
@JoelWee
refactor oppia#10415: refactor out question_validators
52ce36f
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Oct 23, 2020

@JoelWee I have assigned you
@krishita30j krishita30j mentioned this issue Oct 29, 2020
Merged
4 of 4 tasks complete
@iramin
Copy link
Collaborator

@iramin iramin commented Nov 1, 2020

Hi @vojtechjelinek
I would like to work on the config validator.
@iramin iramin mentioned this issue Nov 1, 2020
Closed
4 of 4 tasks complete
@rlhouser rlhouser mentioned this issue Nov 3, 2020
Merged
4 of 4 tasks complete
@jian-en jian-en mentioned this issue Nov 3, 2020
Open
4 of 4 tasks complete
vojtechjelinek pushed a commit that referenced this issue Nov 5, 2020
@purvimisal
Fixes part of #10415: Refactoring story validators (#10973)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d9885fb
vojtechjelinek pushed a commit that referenced this issue Nov 6, 2020
@krishita30j
Fixes part of #10415: Refactor email validators (#11077)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a7e4422
iramin added a commit to iramin/oppia that referenced this issue Nov 7, 2020
@purvimisal @iramin
Fixes part of oppia#10415: Refactoring story validators (oppia#10973)
80302d1
iramin added a commit to iramin/oppia that referenced this issue Nov 7, 2020
@krishita30j @iramin
Fixes part of oppia#10415: Refactor email validators (oppia#11077)
a6c8413
@iramin iramin mentioned this issue Nov 7, 2020
Merged
4 of 4 tasks complete
@KhushiGangopadhyay KhushiGangopadhyay mentioned this issue Nov 8, 2020
Open
kevintab95 pushed a commit that referenced this issue Nov 9, 2020
@kate-perkins @DubeySandeep @vojtechjelinek
Fix part of #10415: Refactor audit validators (#10995)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2954c8c 
* Extract validators for audit models to new module

* Fix lint errors: unused imports and EOL whitespace

* Put floating parameter inside function call

Co-authored-by: Sandeep Dubey <dubeysandeep.in@gmail.com>

* Remove unused constant

* Format to span fewer lines

Co-authored-by: Sandeep Dubey <dubeysandeep.in@gmail.com>

* Update accidentally reverted code

* Undo accidental reverts & remove unused constant

* Undo accidental reversion missed on first pass

* Fix typo and add json.dumps missed on first pass

* Fix lint errors

* Fix merge error: add changes from #10981

* Unpack tuple correctly

Co-authored-by: Vojtěch Jelínek <vojtin.j@gmail.com>

* Match tuple unpacking notation in similar modules

Co-authored-by: Vojtěch Jelínek <vojtin.j@gmail.com>

Co-authored-by: Sandeep Dubey <dubeysandeep.in@gmail.com>
Co-authored-by: Vojtěch Jelínek <vojtin.j@gmail.com>
@MahmoudAmmar-96
Copy link

@MahmoudAmmar-96 MahmoudAmmar-96 commented Nov 10, 2020

Hi @vojtechjelinek. Could I work on the suggestion model?
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Nov 10, 2020

@MahmoudAmmar-96 Yes, I have assigned you.
@nskirkey
Copy link

@nskirkey nskirkey commented Nov 16, 2020

Hi, @vojtechjelinek! I was hoping to be assigned the job models.
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Nov 16, 2020

@nskirkey I have assigned you.
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Nov 16, 2020

@nskirkey Btw, you will need to follow these instructions in order to contribute to Oppia https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia please go throught them.
vojtechjelinek pushed a commit that referenced this issue Nov 16, 2020
@iramin
Fix part of #10415: Extract config validators from prod_validator (#1…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ffd78e0 
…1148)
kevintab95 pushed a commit that referenced this issue Nov 17, 2020
@vextor22 Matt Higgins @vojtechjelinek
Fixes part of #10415: Topic validator refractor (#10967)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
292cc89 
* validators: Refactor topic and subtopic validators into individual validators

* validators: Refactor topic and resolve backend test coverage

* validators: Remove recommendations validator from topic validators file

* validators: Remove unused variable

* validators: Fix docstring naming and update copyright date

* validators: Define model vars in alphabetical order

* validators: Include topic test changes from #10981

* Fix topic validators

* Fix backend tests

* Fix tests

Co-authored-by: Matt Higgins <matt@matthiggins.dev>
Co-authored-by: Vojtěch Jelínek <vojtin.j@gmail.com>
gp201 added a commit to gp201/oppia that referenced this issue Nov 17, 2020
@gp201
Merge pull request #8 from oppia/develop
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7db2b2c 
Fixes part of oppia#10415: Topic validator refractor  (oppia#10967)
@DubeySandeep
Copy link
Member

@DubeySandeep DubeySandeep commented Nov 19, 2020

Assigning @mozammel to the question part of this issue. (As per offline discussion.)
kevintab95 pushed a commit that referenced this issue Nov 20, 2020
@rlhouser Rebekah Houser
Fix part of #10415: Refactor classifier validators (#11116)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52e341a 
* Refactor classifier validators

* Refactor classifier validators

* Refactor classifier validators

* refactor classifier validators

* refactor classifier validators

* Refactor classifier validators

Co-authored-by: Rebekah Houser <rlhouser@Rebekahs-MacBook-Pro.local>
@mozammel mozammel mentioned this issue Nov 20, 2020
Open
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SLoP-25 good first issue
Projects
Data handling
  
TODO (for new contributors)
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.