Use Where-Object instead of alias in buildmodule.tests.ps1 #1360

kvprasoon · 2019-10-26T18:09:12Z

PR Summary

Use Where-Object instead of ? in BuildModule.tests.ps1

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.


        use Where-Object instead of alias

kvprasoon · 2019-10-27T11:21:41Z

@bergmeister any idea on CI failures ?

bergmeister · 2019-10-27T12:44:44Z

The first failure is a relatively new, but known sporadic failure, for which PR #1358 has been opened.
The other 4 failures started to happen only this week without a code change in master and are probably due to a breaking change in an AppVeyor image update.
Concluding, don't worry about them, they are unrelated and not blocking your PR from being merged but ideally, we want to have them fixed in master first before merging more PRs.


        add whitespace after pipe

use Where-Object instead of alias

Loading status checks…

9691527

bergmeister approved these changes Oct 26, 2019

View changes

add whitespace after pipe

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

d8a4d22

bergmeister merged commit 18d0f03 into PowerShell:master Jan 3, 2020
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

license/cla All CLA requirements met.

PowerShell / PSScriptAnalyzer

Use Where-Object instead of alias in buildmodule.tests.ps1 #1360

Use Where-Object instead of alias in buildmodule.tests.ps1 #1360

kvprasoon commented Oct 26, 2019

kvprasoon commented Oct 27, 2019

bergmeister commented Oct 27, 2019 •

edited

PowerShell / PSScriptAnalyzer

Join GitHub today

Use Where-Object instead of alias in buildmodule.tests.ps1 #1360

Use Where-Object instead of alias in buildmodule.tests.ps1 #1360

Conversation

kvprasoon commented Oct 26, 2019

PR Summary

PR Checklist

kvprasoon commented Oct 27, 2019

bergmeister commented Oct 27, 2019 • edited

bergmeister commented Oct 27, 2019 •

edited