benjamingr
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
1,413 contributions in the last year
Activity overview
Contribution activity
November 2020
Created 24 commits in 5 repositories
Created 3 repositories
- benjamingr/wpt HTML
- benjamingr/dom HTML
- benjamingr/undici JavaScript
Created a pull request in nodejs/node that received 23 comments
events: support defining event handlers on prototypes
This PR allows defining event handlers on prototypes and not just on instances.
Fixes a TODO in the code
CC @addaleax
Checklist
make -j4 test (UN…
+66
−19
•
23
comments
Opened 15 other pull requests in 5 repositories
denoland/deno
6
merged
- fix(op_crates/web) make isTrusted not constructable
- fix(web/worker) define event handlers in DOM order
- fix(websocket) correct DOM handler order
- fix(op_crates/web): handler order when reassign
- fix(op_crates/web): define abort event handler on prototype
- fix(web): make onabort event handler web compatible
nodejs/node
2
open
4
closed
web-platform-tests/wpt
1
open
whatwg/dom
1
open
nodejs/undici
1
merged
Reviewed 33 pull requests in 4 repositories
nodejs/node 29 pull requests
- test: improve test-stream-duplex-readable-end
- n-api: improve consistency of how we get context
- doc: fix `added:` info for `stream._construct()`
- test: replace var statements by let statements
- http2: add support for AbortSignal to http2Session.request
- stream: fix thrown object reference
- doc: fix typo in debugger.md
- stream: writableNeedDrain
- test: fix races in test-performance-eventlooputil
- errors: display original symbol name
- tools,lib: recommend using safe primordials
- doc: move v8.getHeapCodeStatistics()
- module: refactor to use more primordials
- lib: fix inspector links for stack traces
- events: graduate Event, EventTarget, AbortController
- events: add max listener warning for EventTarget
- test: use global.EventTarget instead of internals
- lib: add %TypedArray% abstract constructor to primordials
- timers: cleanup abort listener on awaitable timers
- bootstrap: refactor to use more primordials
- test: move test-worker-eventlooputil to sequential
- fs: replace finally with PromisePrototypeFinally
- tools,doc: enable ecmaVersion 2021 in acorn parser
- module: refactor to use iterable-weak-map
- errors: refactor to use more primordials
- Some pull request reviews not shown.
testimio/root-cause 2 pull requests
mobxjs/mobx-react-lite 1 pull request
denoland/deno 1 pull request
Created an issue in nodejs/node that received 18 comments
Warn on EventTarget maxListeners > THRESHOLD
tl;dr; I want to add the "max listener warning" to all event targets (and not just NodeEventTarget) I checked with WHATWG and we are allowed to do…
18
comments
Opened 8 other issues in 3 repositories
testimio/root-cause
5
open
nodejs/node
2
open
tc39/proposal-weakrefs
1
open
8
contributions
in private repositories
Nov 2 – Nov 10