Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to build with caching to help build times #1051

Merged
merged 23 commits into from Dec 4, 2020
Merged

Conversation

admiralAwkbar
Copy link
Collaborator

@admiralAwkbar admiralAwkbar commented Dec 3, 2020

  • Trying out action to use docker cache to help build dev times

@admiralAwkbar admiralAwkbar self-assigned this Dec 4, 2020
@admiralAwkbar admiralAwkbar added automation docker labels Dec 4, 2020
@admiralAwkbar
Copy link
Collaborator Author

@admiralAwkbar admiralAwkbar commented Dec 4, 2020

So for now, were not seeing any major gains in speed, but I would assume once this is working in sync, we should see better build times as caching the image is a good idea...

Also, it takes us away from the custom bash scripts and more of an actions approach...

Not a bad idea...

@admiralAwkbar admiralAwkbar merged commit 37b098d into master Dec 4, 2020
1 check passed
@admiralAwkbar admiralAwkbar deleted the DockerBuildWithCache branch Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation docker
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants