JavaScript: Factor out HTML extractor#4744
Merged
Merged
Conversation
sauyon
added
the
depends on internal PR
sauyon
force-pushed
the
sauyon/html-refactor
branch
from
890156a to
8d55fdc
Compare
sauyon
force-pushed
the
sauyon/html-refactor
branch
from
8d55fdc to
1643121
Compare
sauyon
force-pushed
the
sauyon/html-refactor
branch
from
1643121 to
b215fcc
Compare
smowton
reviewed
Dec 1, 2020
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
+400, -600 -- is there a missing file?
| new ScopeManager(textualExtractor.getTrapwriter(), config.getEcmaVersion()); | ||
| } | ||
|
|
||
| /* |
Contributor
There was a problem hiding this comment.
Weird indentation (autoformat?)
| xmlElements(#20001,"html",#10000,0,#10000) | ||
| #20002=@"loc,{#10000},1,1,25,7" | ||
| locations_default(#20002,#10000,1,1,25,7) | ||
| xmlChars(#20001," |
Contributor
There was a problem hiding this comment.
I thought this would just be a refactor; why have test results changed?
Contributor
Author
There was a problem hiding this comment.
Tuples moved around because the extraction order changed.
Contributor
|
Ah wait sorry, I get it -- code is moving between repos. |
sauyon
force-pushed
the
sauyon/html-refactor
branch
2 times, most recently
from
ba3c452 to
639e22e
Compare
Contributor
|
Sorry, I forgot to mention this earlier, but could you bump the extractor version string in |
sauyon
force-pushed
the
sauyon/html-refactor
branch
from
639e22e to
17e450f
Compare
asgerf
approved these changes
Dec 7, 2020
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
Happy to see this merged. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor out HTML extraction into a library in order to create a standalone HTML extractor.