PowerShell / PSReadLine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the release build #1930

Merged

daxian-dbw merged 4 commits into PowerShell:master from daxian-dbw:release-build

Nov 4, 2020

Member

daxian-dbw commented Nov 4, 2020 •

edited by msftbot bot

PR Summary

Update the release build:

Use a new builder pool, which has the latest PowerShell 7.0.3 available.
Remove catalog related steps, as the catalog file is unnecessary to PowerShell Gallery now.
Update the signing xml file to sign the new "Polyfiller" assemblies.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure you've added one or more new tests
User-facing changes
- Not Applicable
- OR
- Documentation needed at PowerShell-Docs
  - Doc Issue filed:

Microsoft Reviewers: Open in CodeFlow

daxian-dbw added 3 commits


          Update the pool to use

3cdee0c


          Update release build to:

d51d5cd

1. Update the signing xml file
2. Remove catalog related steps


          Update pool name again

62adf3f

daxian-dbw requested review from lzybkr and SteveL-MSFT

Member Author

daxian-dbw commented Nov 4, 2020

This change has been verified with the Azure DevOps build https://dev.azure.com/mscodehub/PSReadLine/_build/results?buildId=158037&view=results

adityapatwardhan suggested changes

.vsts-ci/releaseBuild.yml

  
      @@ -17,7 +17,7 @@ resources:
    
        jobs:

        - job: build_windows

          pool: Package ES Lab A

          pool: Package ES CodeHub Lab E

adityapatwardhan Nov 4, 2020
Member

This should be the standard pool Package ES Standard Build. Did you have problems using it? It seems you had it in one of your previous commits

daxian-dbw Nov 4, 2020
Author Member

Yes, the build didn't start when using Package ES Standard Build. It says something like "it doesn't exist or I don't have permission". I copied this one from Paul's SecretManagement release build.

daxian-dbw Nov 4, 2020
Author Member

I just sent the email to request adding the agent pool to PSReadLine. I will update the pool name once the agent pool is added and my access is clear.
Before that, I would like to go with "Package ES CodeHub Lab E", as I need to release 2.2.0-beta1 today or tomorrow.

msftbot bot added Needs-Author Feedback and removed Needs-Author Feedback labels

adityapatwardhan reviewed

.vsts-ci/sign-module-files.xml Outdated Show resolved Hide resolved

adityapatwardhan approved these changes

Member

adityapatwardhan left a comment

Approved when the pool is changed.


          Skip signing 'System.Runtime.InteropServices.RuntimeInformation.dll' …

e309359

…as it's already signed

SteveL-MSFT approved these changes

daxian-dbw merged commit 417fe5c into PowerShell:master

2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded

Details

license/cla All CLA requirements met.

Details

daxian-dbw deleted the daxian-dbw:release-build branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.