bpo-42485: [Doc] Link to PEP 617 from full grammar specification #23532
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: @SnoopJeDi For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Thanks for the PR @SnoopJeDi. Could you follow these instructions (#23532 (comment)) to sign up the CLA so I can review and merge the PR? :) |
I've signed the CLA and received a copy by email, so I assume we're waiting on the bot to take notice of this. Will check back tomorrow! (apologies if you received two notifications about this, I accidentally replied with another account at first) |
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution, @SnoopJeDi! We've got a custom pep rst directive, which should be used to link to PEPs.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I expect that our office manager took today off in addition to Thanksgiving yesterday. So I expect no CLA link until Monday. |
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
|
Cheers for the review and the directive. I have made the requested changes; please review again |
|
Thanks for making the requested changes! @lysnikolaou: please review the changes made to this pull request. |
|
Thanks for the PR @SnoopJeDi ! |
…honGH-23532) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
6 participants
Now that CPython uses the new PEG parser, it would be helpful to include a reference to the guiding PEP (617) on the docs page (https://docs.python.org/3/reference/grammar.html) that gives the grammar.
https://bugs.python.org/issue42485
https://bugs.python.org/issue42485